You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/22 07:15:29 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #8717: Fixes CuratorZookeeperRepositoryTest test errors
menghaoranss opened a new pull request #8717:
URL: https://github.com/apache/shardingsphere/pull/8717
Fixes #8646 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8717: Fixes CuratorZookeeperRepositoryTest test errors
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8717:
URL: https://github.com/apache/shardingsphere/pull/8717#issuecomment-749445143
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=h1) Report
> Merging [#8717](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=desc) (14f9706) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aeef1633bfece1739fd3f76abe4ce534e52c80ee?el=desc) (aeef163) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8717/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8717 +/- ##
============================================
- Coverage 70.93% 70.89% -0.04%
+ Complexity 623 621 -2
============================================
Files 1575 1572 -3
Lines 25200 25164 -36
Branches 4404 4403 -1
============================================
- Hits 17875 17841 -34
+ Misses 6150 6137 -13
- Partials 1175 1186 +11
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rdingsphere/agent/metrics/api/MetricsProvider.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvTWV0cmljc1Byb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/agent/core/config/AgentConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvQWdlbnRDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
| [...ere/scaling/core/utils/RdbmsConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9SZGJtc0NvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `40.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...che/shardingsphere/agent/core/yaml/YamlEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS95YW1sL1lhbWxFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (-36.37%)` | `0.00% <0.00%> (ø%)` | |
| [...i/prometheus/PrometheusMetricsRegisterFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljc1JlZ2lzdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rdingsphere/proxy/database/DatabaseServerInfo.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9kYXRhYmFzZS9EYXRhYmFzZVNlcnZlckluZm8uamF2YQ==) | `90.00% <0.00%> (-10.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/execute/executor/dumper/AbstractJDBCDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2R1bXBlci9BYnN0cmFjdEpEQkNEdW1wZXIuamF2YQ==) | `83.33% <0.00%> (-7.15%)` | `0.00% <0.00%> (ø%)` | |
| [.../text/sctl/show/ShardingCTLShowBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvc2hvdy9TaGFyZGluZ0NUTFNob3dCYWNrZW5kSGFuZGxlci5qYXZh) | `86.66% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.75% <0.00%> (-6.25%)` | `0.00% <0.00%> (ø%)` | |
| [...caling/mysql/component/MySQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTERhdGFTb3VyY2VDaGVja2VyLmphdmE=) | `88.63% <0.00%> (-4.55%)` | `1.00% <0.00%> (ø%)` | |
| ... and [30 more](https://codecov.io/gh/apache/shardingsphere/pull/8717/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=footer). Last update [aeef163...14f9706](https://codecov.io/gh/apache/shardingsphere/pull/8717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yu199195 merged pull request #8717: Fixes CuratorZookeeperRepositoryTest test errors
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #8717:
URL: https://github.com/apache/shardingsphere/pull/8717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org