You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/21 06:11:28 UTC
[GitHub] [incubator-doris] yiguolei opened a new pull request #7451: [Compile] Support build with clang
yiguolei opened a new pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451
Support build Doris BE with clang
Currently, thirdparty could only be build with GCC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei commented on pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#issuecomment-999251390
> Maybe provide clang in thrid-party or docker image? And make `build with clang` an optional args?
Currently, could only build be with clang, And I don't want it to be an optional args because I think we should use clang as default build tool chain in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773101489
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
I think this should be an optional choice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773571349
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx
We define GCC HOME because bitshuffle's build process depend on GCC_HOME/ld. I will rewrite bitshuffle build method use cmake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei closed pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773571349
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx
I will remove GCC HOME and rewrite bitshuffle build method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#issuecomment-998704340
Maybe provide clang in thrid-party or docker image?
And make ```build with clang``` an optional args?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773571349
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx
I will remove GCC HOME and rewrite bitshuffle build method, it is very ugly....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7451: [Compile] Support build with clang
Posted by GitBox <gi...@apache.org>.
yiguolei commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773574755
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
If we want to build with clang, then we export CC=XXXX/clang and CXX=XXXXXXX/clang++
If we want to build with gcc, then we export CC=xxxx/gcc and CXX=xxxxx/g++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org