You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/26 06:06:24 UTC

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

sunjincheng121 commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink
URL: https://github.com/apache/flink/pull/8225#discussion_r278817480
 
 

 ##########
 File path: flink-dist/pom.xml
 ##########
 @@ -428,9 +411,6 @@ under the License.
 									<goal>single</goal>
 								</goals>
 								<configuration>
-									<descriptors>
-										<descriptor>src/main/assemblies/hadoop.xml</descriptor>
 
 Review comment:
   Yes, I think we should keep `include-hadoop` available. and we can download the jar by change the `hadoop.xml`. i.e.: `files` ->`dependencySet`.  and `Rework flink-dist assemblies` changes can in a new PR. What do you think? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services