You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "Arkelenia (via GitHub)" <gi...@apache.org> on 2025/03/16 04:12:38 UTC
[PR] [GCP IMDS] Use fully qualified name [libcloud]
Arkelenia opened a new pull request, #2060:
URL: https://github.com/apache/libcloud/pull/2060
## Use the fully-qualified name for the GCP IMDS endpoint
### Description
This PR replaces the current IMDS endpoint `http://metadata/computeMetadata/v1/...` with the fully-qualified name version `http://metadata.google.internal/computeMetadata/v1/...`.
The current state assumes the presence of `google.internal` as a search domain to work properly which may not be the case when the endpoint is resolved from a container or a Kubernetes pod running on a GCP node.
### Status
ready for review
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GCP IMDS] Use fully qualified name [libcloud]
Posted by "micafer (via GitHub)" <gi...@apache.org>.
micafer merged PR #2060:
URL: https://github.com/apache/libcloud/pull/2060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GCP IMDS] Use fully qualified name [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2060:
URL: https://github.com/apache/libcloud/pull/2060#issuecomment-3883988993
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2060?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 83.35%. Comparing base ([`6a7f04a`](https://app.codecov.io/gh/apache/libcloud/commit/6a7f04a0d65ab014e3e995be2c1114b5e6dc03e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6f6772`](https://app.codecov.io/gh/apache/libcloud/commit/b6f677256dd115bd946395481dc492d5ccb57b06?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2060?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [libcloud/common/google.py](https://app.codecov.io/gh/apache/libcloud/pull/2060?src=pr&el=tree&filepath=libcloud%2Fcommon%2Fgoogle.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/libcloud/pull/2060?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2060 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 353 353
Lines 81848 81848
Branches 8998 8998
=======================================
Hits 68224 68224
Misses 10797 10797
Partials 2827 2827
```
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2060?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libcloud/common/google.py](https://app.codecov.io/gh/apache/libcloud/pull/2060?src=pr&el=tree&filepath=libcloud%2Fcommon%2Fgoogle.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `71.35% <0.00%> (ø)` | |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org