You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by GitBox <gi...@apache.org> on 2021/12/27 20:47:19 UTC
[GitHub] [ws-wss4j] hboutemy opened a new pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
hboutemy opened a new pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42
fixes Reproducible Builds issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] hboutemy commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1003057181
uh, how is it possible?
I added an IT in maven-bundle-plugin 5.1.3 to check that it does not happen:
- https://github.com/apache/felix-dev/commit/be537033353c575a33d85a8653a0df056b54bfa2
- https://github.com/apache/felix-dev/commit/957e5c9838aa67061888760286cb78251bee50bd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] veithen commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
veithen commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1003008654
Note that with this change, the bundle manifests still have a `Bnd-LastModified` header, i.e. the build is not deterministic/reproducible. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] veithen closed pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
veithen closed pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] hboutemy commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1003106288
bug reported to Felix and PR provided: https://issues.apache.org/jira/browse/FELIX-6495
we'll need to wait for 5.1.4 to have a fixed bundle:manifest goal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] hboutemy commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1003060871
just tested: with default packaging (default to `jar`), yes, there is the `Bnd-LastModified` header
but using `<packaging>bundle</packaging>`, it disappears (as expected)
is there a reason to not use `bundle` packaging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] veithen commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
veithen commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1003066904
They actually used to have `bundle` packaging, but that was changed in https://github.com/apache/ws-wss4j/commit/9a3bcc1a4b0d685e53a8b1a5b121df1b4a371e71. The commit description doesn't explain why that was done though. Maybe @dkulp remembers? Also, it looks like there are no tests that validate that the bundles work properly, so changes are risky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] veithen commented on pull request #42: upgrade Felix maven-bundle-plugin to 5.1.3
Posted by GitBox <gi...@apache.org>.
veithen commented on pull request #42:
URL: https://github.com/apache/ws-wss4j/pull/42#issuecomment-1008002335
Looks like maven-bundle-plugin 5.1.4 fixes that problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org