[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11677: feat: generic timeout

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #11677:
URL: https://github.com/apache/dubbo/pull/11677#discussion_r1134826336


##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -375,6 +375,9 @@ protected void processExtraRefresh(String preferredPrefix, InmemoryConfiguration
     }
 
     private boolean verifyMethodConfig(MethodConfig methodConfig, Class<?> interfaceClass, boolean ignoreInvalidMethodConfig) {
+        if (!isNeedCheckMethod()) {
+            return true;
+        }

Review Comment:
   It would be better to check anyway, but warn out only instead of throw a exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org