You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Janne Hietamäki (JIRA)" <ji...@apache.org> on 2008/02/06 15:09:09 UTC
[jira] Created: (WICKET-1326) remove final from
AjaxRequestTarget.addComponent(Component)
remove final from AjaxRequestTarget.addComponent(Component)
-----------------------------------------------------------
Key: WICKET-1326
URL: https://issues.apache.org/jira/browse/WICKET-1326
Project: Wicket
Issue Type: Task
Affects Versions: 1.3.1
Reporter: Janne Hietamäki
Assignee: Janne Hietamäki
Ajax behaviors are currently extremely hard to test because the final method AjaxRequestTarget.addComponent(Component) is final and can't be mocked.
Does anyone object removing the final keyword?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1326) remove final from
AjaxRequestTarget.addComponent(Component)
Posted by "Janne Hietamäki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Hietamäki resolved WICKET-1326.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.2
done
> remove final from AjaxRequestTarget.addComponent(Component)
> -----------------------------------------------------------
>
> Key: WICKET-1326
> URL: https://issues.apache.org/jira/browse/WICKET-1326
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.1
> Reporter: Janne Hietamäki
> Assignee: Janne Hietamäki
> Fix For: 1.3.2
>
>
> Ajax behaviors are currently extremely hard to test because the final method AjaxRequestTarget.addComponent(Component) is final and can't be mocked.
> Does anyone object removing the final keyword?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1326) remove final from
AjaxRequestTarget.addComponent(Component)
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566136#action_12566136 ]
Timo Rantalaiho commented on WICKET-1326:
-----------------------------------------
This would be excellent, as it would make unit testing ajax repaints much easier (often you need to test which components get added to AjaxRequestTarget).
> remove final from AjaxRequestTarget.addComponent(Component)
> -----------------------------------------------------------
>
> Key: WICKET-1326
> URL: https://issues.apache.org/jira/browse/WICKET-1326
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.1
> Reporter: Janne Hietamäki
> Assignee: Janne Hietamäki
>
> Ajax behaviors are currently extremely hard to test because the final method AjaxRequestTarget.addComponent(Component) is final and can't be mocked.
> Does anyone object removing the final keyword?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1326) remove final from
AjaxRequestTarget.addComponent(Component)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566135#action_12566135 ]
Johan Compagner commented on WICKET-1326:
-----------------------------------------
not me
> remove final from AjaxRequestTarget.addComponent(Component)
> -----------------------------------------------------------
>
> Key: WICKET-1326
> URL: https://issues.apache.org/jira/browse/WICKET-1326
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.1
> Reporter: Janne Hietamäki
> Assignee: Janne Hietamäki
>
> Ajax behaviors are currently extremely hard to test because the final method AjaxRequestTarget.addComponent(Component) is final and can't be mocked.
> Does anyone object removing the final keyword?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.