[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9753: feat: convert backend chart errors to the new error type

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #9753:
URL: https://github.com/apache/incubator-superset/pull/9753#discussion_r434902313



##########
File path: superset-frontend/src/utils/getClientErrorObject.ts
##########
@@ -48,6 +50,12 @@ export default function getClientErrorObject(
           .json()
           .then(errorJson => {
             let error = { ...responseObject, ...errorJson };
+
+            // Backwards compatibility for old error renderers with the new error object
+            if (error.errors && error.errors.length > 0) {

Review comment:
       I suspect this new line cause some error_details logged as empty.
   this is how front-end use error field:
   https://github.com/apache/incubator-superset/blob/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b/superset-frontend/src/chart/chartAction.js#L403




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org