You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/02/20 10:36:28 UTC
[GitHub] zeppelin pull request #2809: [ZEPPELIN-3249] Add support for streaming table
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2809
[ZEPPELIN-3249] Add support for streaming table
### What is this PR for?
Since Zeppelin support streaming from various backends, I think it will be useful if even tables (and later graphs) can also be streamed.
### What type of PR is it?
[Improvement | Feature]
### What is the Jira issue?
* [ZEPPELIN-3249](https://issues.apache.org/jira/browse/ZEPPELIN-3249)
### How should this be tested?
I have done it using shell interpreter, but this should work for all other backends as well
```
%sh
echo "%table"
echo "Col1 Col2"
echo "1 2"
sleep 1
echo "3 4"
echo "5 6"
sleep 2
echo "7 8"
sleep 3
echo "9 10"
echo "11 12"
sleep 4
echo "12 13"
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3249
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2809.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2809
----
commit 21564fcb4f336867e1b628445c0f194ccc3ed574
Author: Prabhjyot Singh <pr...@...>
Date: 2018-02-16T09:45:20Z
Add support for streaming table
Change-Id: If47e6646755ed47463fec9c2ab38adeaec700053
----
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2809
Tested. LGTM.
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2809
I think as a nice side effect, this PR also fixes https://issues.apache.org/jira/browse/ZEPPELIN-3238 - see comments there
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2809
Thanks for the review will merge this to master and branch-0.8 if no more discussion.
---
[GitHub] zeppelin pull request #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2809
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2809
Sure, let me take a look.
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2809
seems like it has changed table behavior when height of paragraph has been changed.
https://issues.apache.org/jira/browse/ZEPPELIN-3289
@prabhjyotsingh can you fix that bug?
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2809
Here is another example for python.
```
%python
print "%table col1 col2"
print "i 1 i 1"
wait_time = 2
import time
time.sleep(1)
for x in range(2, 200):
print "i",x," i",x
if x == wait_time:
time.sleep(2)
wait_time = wait_time*2
```
---
[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2809
@r-kamath can you help review this PR
---