You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2017/10/12 05:37:18 UTC
Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62903/#review187738
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['62502', '62903']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62903
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62903/logs/mesos-tests-build-cmake-stdout.log):
```
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\common\type_utils_tests.cpp) [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\mesos\src\tests\mesos-tests.vcxproj]
"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\mesos\mesos\src\tests\resource_provider_manager_tests.cpp(222): error C2039: 'mutable_resources': is not a member of 'mesos::v1::resource_provider::Call_Subscribe' [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_manager_tests.cpp(222): error C2227: left of '->CopyFrom' must point to class/struct/union/generic type [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(60): error C2039: 'UPDATE': is not a member of 'mesos::resource_provider::Call' [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(60): error C2065: 'UPDATE': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(73): error C2039: 'Update': is not a member of 'mesos::resource_provider::Call' [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(73): error C2065: 'Update': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(73): error C2065: 'update': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(73): error C2039: 'mutable_update': is not a member of 'mesos::resource_provider::Call' [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(74): error C2065: 'update': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(74): error C2227: left of '->set_state' must point to class/struct/union/generic type [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(74): error C3083: 'Update': the symbol to the left of a '::' must be a type [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(74): error C2039: 'OK': is not a member of 'mesos::resource_provider::Call' [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(74): error C2065: 'OK': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(75): error C2065: 'update': undeclared identifier [C:\mesos\src\tests\mesos-tests.vcxproj]
C:\mesos\mesos\src\tests\resource_provider_validation_tests.cpp(75): error C2227: left of '->mutable_operation' must point to class/struct/union/generic type [C:\mesos\src\tests\mesos-tests.vcxproj]
454 Warning(s)
15 Error(s)
Time Elapsed 01:05:34.82
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62903/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_0778a.dir\Debug\cmTC_0778a.tlog\".
InitializeBuildStatus:
Creating "cmTC_0778a.dir\Debug\cmTC_0778a.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_0778a.dir\Debug\" /Fd"cmTC_0778a.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_0778a.dir\Debug\" /Fd"cmTC_0778a.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_0778a.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0778a.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0778a.lib" /MACHINE:X64 /machine:x64 cmTC_0778a.dir\Debug\src.obj
cmTC_0778a.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_0778a.exe
cmTC_0778a.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0778a.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_0778a.dir\Debug\cmTC_0778a.tlog\unsuccessfulbuild".
Touching "cmTC_0778a.dir\Debug\cmTC_0778a.tlog\cmTC_0778a.lastbuildstate".
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_0778a.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.76
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62903/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_c3623.dir\Debug\".
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_c3623.dir\Debug\cmTC_c3623.tlog\".
InitializeBuildStatus:
Creating "cmTC_c3623.dir\Debug\cmTC_c3623.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c3623.dir\Debug\" /Fd"cmTC_c3623.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c3623.dir\Debug\" /Fd"cmTC_c3623.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_c3623.vcxproj]
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_c3623.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\mesos\CMakeFiles\CMakeTmp\cmTC_c3623.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_c3623.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.84
```
- Mesos Reviewbot Windows
On Oct. 11, 2017, 10:13 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62903/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now a resource provider can first `SUBSCRIBE` to the resource provider
> manager without resources to get its ID, then use the ID to locate the
> checkpoints for recovery and prepare persistent work directory, and then
> update its total resources later through `UPDATE_TOTAL_RESOURCE`.
>
> This patch also renames `UPDATE` to `UPDATE_OPERATION_STATUS`.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845
> include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c
> src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3
> src/resource_provider/validation.cpp d2927227f60ab0d4ae2481ad73a31ee444b48ee0
>
>
> Diff: https://reviews.apache.org/r/62903/diff/2/
>
>
> Testing
> -------
>
> make tests
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>