You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by du...@apache.org on 2022/10/16 12:28:04 UTC

[rocketmq] branch develop updated: disable commit offset if not enable autocommit (#5316)

This is an automated email from the ASF dual-hosted git repository.

duhengforever pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new d17440469 disable commit offset if not enable autocommit (#5316)
d17440469 is described below

commit d17440469e44c044487418b92b1450751d6a66ee
Author: lizhiboo <li...@yeah.net>
AuthorDate: Sun Oct 16 20:27:57 2022 +0800

    disable commit offset if not enable autocommit (#5316)
---
 .../rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
index 90dc9b3b9..cff968cd6 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
@@ -1112,6 +1112,10 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner {
 
     @Override
     public void persistConsumerOffset() {
+        // this method will be called by MQInstance schedule task, commit offset depends on autocommit config
+        if (!this.defaultLitePullConsumer.isAutoCommit()) {
+            return;
+        }
         try {
             checkServiceState();
             Set<MessageQueue> mqs = new HashSet<>();