[GitHub] [iceberg] namrathamyske commented on a diff in pull request #4926: Core, API: Append/Delete changes to snapshot branch

[GitBox <gi...@apache.org>]

namrathamyske commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r902944744


##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,4 +60,9 @@
    * @return this for method chaining
    */
   ThisT scanManifestsWith(ExecutorService executorService);
+
+  /**
+   * Perform operations a particular branch

Review Comment:
   @amogh-jahagirdar All validations must start from tip of branch, aka the current snapshot in the branch. So all the operations which override the ` protected void validate(TableMetadata currentMetadata) { }` aka - BaseOverwriteFiles, BaseReplacePartitions, BaseRewriteFiles, BaseRowDelta need to reference the current snapshot from the branch tip. 
   
   Is any other validation needed here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org