You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "kapchew (via GitHub)" <gi...@apache.org> on 2023/05/25 08:37:58 UTC
[GitHub] [cordova-plugin-screen-orientation] kapchew opened a new issue, #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
kapchew opened a new issue, #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119
### Issue Type
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [ x ] Bug Report
- [ ] Feature Request
- [ ] Support Question
## Description
When testing in iOS 16.4 and 16.5, code execution stops at screen.orientation.lock();
### Environment, Platform, Device
MacBook Pro M1 + iPad
### Version information
Cordova CLI 11
cordova-ios 6.3
cordova-plugin-screen-orientation 3.0.3
## Checklist
- [ x ] I searched for already existing GitHub issues about this
- [ x ] I updated all Cordova tooling to their most recent version
- [ x ] I included all the necessary information above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] erisu commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1710013087
Resolved in #116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] ragcsalo commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "ragcsalo (via GitHub)" <gi...@apache.org>.
ragcsalo commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1587859907
Nope, unfortunately the workaround doesn't work on older iOS versions. So we have to do this:
www/**screenorientation.js**, around **line 98**:
```
if (typeof ScreenOrientation != 'undefined') {
addScreenOrientationApi(ScreenOrientation.prototype);
}
else {
addScreenOrientationApi(screen.orientation);
}
```
This works for me on iOS 16.5 and also 15.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] DeveloperHitesh commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "DeveloperHitesh (via GitHub)" <gi...@apache.org>.
DeveloperHitesh commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1573254311
Facing similar issue while trying to open camera in application.
ERROR: Unhandled Promise rejection: plugin_not_installed ; Zone: ; Task: Promise.then ; Value: plugin_not_installed
WARN: Native: tried calling ScreenOrientation.lock, but the ScreenOrientation plugin is not installed.
WARN: Install the ScreenOrientation plugin: 'ionic cordova plugin add cordova-plugin-screen-orientation'
ERROR: Unhandled Promise rejection: plugin_not_installed ; Zone: ; Task: Promise.then ; Value: plugin_not_installed
WARN: Native: tried calling ScreenOrientation.lock, but the ScreenOrientation plugin is not installed.
WARN: Install the ScreenOrientation plugin: 'ionic cordova plugin add cordova-plugin-screen-orientation'
ERROR: Unhandled Promise rejection: plugin_not_installed ; Zone: ; Task: Promise.then ; Value: plugin_not_installed
This issue is occure after getting update of ios version 16.4 and 16.5, on lower version i'm able to access camera easily.
Below plugin used for
"cordova-ios": "^6.3.0",
"@ionic-native/camera-preview": "^5.27.0",
"cordova-plugin-camera-preview": "^0.12.3",
"cordova-plugin-screen-orientation": "^3.0.2"
Reference link for similar issue : https://github.com/ionic-team/capacitor/issues/6459
Implemented this change on local but not working : https://github.com/apache/cordova-plugin-screen-orientation/commit/f8479d5c7bc938edf782bf4ebcedc0cfa8ceb7e8
Can you help me on this any pointers on same it will help full for me.
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] erisu closed issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu closed issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] FreddieFred34 commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "FreddieFred34 (via GitHub)" <gi...@apache.org>.
FreddieFred34 commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1608844035
> Nope, unfortunately the workaround doesn't work on older iOS versions. So we have to do this: www/**screenorientation.js**, around **line 98**:
>
> ```
> if (typeof ScreenOrientation != 'undefined') {
> addScreenOrientationApi(ScreenOrientation.prototype);
> }
> else {
> addScreenOrientationApi(screen.orientation);
> }
> ```
>
> This works for me on iOS 16.5 and also 15.7
Fantastic this did indeed do the trick! Important is that you edit the correct screenorientation.js file :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] richpixel commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "richpixel (via GitHub)" <gi...@apache.org>.
richpixel commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1580787630
I've been tinkering a little and notice that changing
`screenObject.lock = function (orientation) {`
to
`ScreenOrientation.prototype.lock = function (orientation) {`
fixes the problem of the lock function being undefined. I'm not sure how iOS versions less than 16.4 will handle this, so more testing needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] richpixel commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "richpixel (via GitHub)" <gi...@apache.org>.
richpixel commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1579694778
Hi-
I'm also seeing this issue when building my app. Luckily upgrading to 16.5 on devices that already have the app installed does not cause them to fail. If I put the call to screen.orientation.lock() in a try/catch block I get the following exception:
TypeError: window.screen.orientation.lock is not a function. (In 'window.screen.orientation.lock(e)', 'window.screen.orientation.lock' is undefined)
I'm looking into a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] EbenDang commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "EbenDang (via GitHub)" <gi...@apache.org>.
EbenDang commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1652472289
Hi guys. There is a PR to fix it. How soon it can be merged? @maverickmishra @purplecabbage @alsorokin @janpio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] DeveloperHitesh commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "DeveloperHitesh (via GitHub)" <gi...@apache.org>.
DeveloperHitesh commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1588546649
Due to xcode version update from 14.2 to 14.3 we are facing this issue, Again we moved from 14.3 to 14.2 issue is resolved, don't know what is update in xcode version but after downgrade xcode version resolved my issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] FreddieFred34 commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "FreddieFred34 (via GitHub)" <gi...@apache.org>.
FreddieFred34 commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1608018133
Is there an update about this issue? Facing the same issue.
Is there maybe a work around to force the app to Landscape mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] richpixel commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "richpixel (via GitHub)" <gi...@apache.org>.
richpixel commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1608078960
> Is there an update about this issue? Facing the same issue.
>
> Is there maybe a work around to force the app to Landscape mode?
Look at the comment from ragcsalo, if you're able to edit that one js file, it solves the issue. I would consider this a workaround, but it's fine until the plugin author releases an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] playrobotics-alex commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "playrobotics-alex (via GitHub)" <gi...@apache.org>.
playrobotics-alex commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1608094104
I just forced orientation to landscape of the whole app in xcode, that worked for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] deepakrout commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "deepakrout (via GitHub)" <gi...@apache.org>.
deepakrout commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1563186401
Hi There, I am also facing same issue, particularly in iOS 16.4 and above devices. Below iOS 16.4, the plugin works fine. In iOS 16.4 XCode debug console prints error:
`Native: tried calling Screen Orientation.lock, but the Screen Orientation plugin is not installed.`
Essentially, the it is not calling the plugin method at all. Breakpoints doesn't hit.
Is there any update/solution for this?
If someone can at least point me why it would through error _plugin not installed_, I can work on this issue to address this.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] playrobotics-alex commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "playrobotics-alex (via GitHub)" <gi...@apache.org>.
playrobotics-alex commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1581552635
> ScreenOrientation.prototype.lock
Great find! Please let us know when you have news about previous versions, I will try to find an old iphone to test as well....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] gauravpatil79 commented on issue #119: iOS 16.4 and 16.5 stops at screen.orientation.lock()
Posted by "gauravpatil79 (via GitHub)" <gi...@apache.org>.
gauravpatil79 commented on issue #119:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/119#issuecomment-1633747750
>
any idea how long it will take for the updated version of plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org