You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/11 11:03:57 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #5492: [INLONG-5491][Manager] Fix pulsar failed to configure nonpartitioned topic problem
fuweng11 opened a new pull request, #5492:
URL: https://github.com/apache/inlong/pull/5492
### Prepare a Pull Request
- Fixes #5491
### Motivation
Fix pulsar failed to configure nonpartitioned topic problem
### Modifications
When creating topic, judge whether to partition
### Verifying this change
*(Please pick either of the following options)*
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5492: [INLONG-5491][Manager] Fix the error of configuring the Pulsar nonpartitioned topic
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5492:
URL: https://github.com/apache/inlong/pull/5492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5492: [INLONG-5491][Manager] Fix pulsar failed to configure nonpartitioned topic problem
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5492:
URL: https://github.com/apache/inlong/pull/5492#discussion_r944128799
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -316,19 +321,29 @@ public boolean topicIsExists(PulsarAdmin pulsarAdmin, String tenant, String name
return topicExists;
}
- private boolean subscriptionIsExists(PulsarAdmin pulsarAdmin, String topic, String subscription) {
+ private boolean subscriptionIsExists(PulsarAdmin pulsarAdmin, PulsarTopicBean topicBean, String subscription) {
Review Comment:
It is recommended to pass in a field of whether it is a partitioned topic.
Such as `boolean isPartitionedTopic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5492: [INLONG-5491][Manager] Fix pulsar failed to configure nonpartitioned topic problem
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5492:
URL: https://github.com/apache/inlong/pull/5492#issuecomment-1212678402
@woofyzhao @gong PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org