You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/18 20:36:28 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #36600: [SPARK-39212][SQL][3.3] Use double quotes for values of SQL configs/DS options in error messages
MaxGekk opened a new pull request, #36600:
URL: https://github.com/apache/spark/pull/36600
### What changes were proposed in this pull request?
Wrap values of SQL configs and datasource options in error messages by double quotes. Added the `toDSOption()` method to `QueryErrorsBase` to quote DS options.
This is a backport of https://github.com/apache/spark/pull/36579.
### Why are the changes needed?
1. To highlight SQL config/DS option values and make them more visible for users.
2. To be able to easily parse values from error text.
3. To be consistent to other outputs of identifiers, sql statement and etc. where Spark uses quotes or ticks.
### Does this PR introduce _any_ user-facing change?
Yes, it changes user-facing error messages.
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt "testOnly *QueryCompilationErrorsSuite"
$ build/sbt "testOnly *QueryExecutionAnsiErrorsSuite"
$ build/sbt "testOnly *QueryExecutionErrorsSuite"
```
Authored-by: Max Gekk <ma...@gmail.com>
Signed-off-by: Max Gekk <ma...@gmail.com>
(cherry picked from commit 96f4b7dbc1facd1a38be296263606aa312861c95)
Signed-off-by: Max Gekk <ma...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #36600: [SPARK-39212][SQL][3.3] Use double quotes for values of SQL configs/DS options in error messages
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #36600: [SPARK-39212][SQL][3.3] Use double quotes for values of SQL configs/DS options in error messages
URL: https://github.com/apache/spark/pull/36600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36600: [SPARK-39212][SQL][3.3] Use double quotes for values of SQL configs/DS options in error messages
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36600:
URL: https://github.com/apache/spark/pull/36600#issuecomment-1131192205
@HyukjinKwon @cloud-fan @gengliangwang Could you approve the backport, please. Also cc @srielau .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36600: [SPARK-39212][SQL][3.3] Use double quotes for values of SQL configs/DS options in error messages
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36600:
URL: https://github.com/apache/spark/pull/36600#issuecomment-1131420222
Thanks, merging to 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org