You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/10 00:48:16 UTC
[kudu-CR] master: do not crash on /dump-entities during startup
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4366
to review the following change.
Change subject: master: do not crash on /dump-entities during startup
......................................................................
master: do not crash on /dump-entities during startup
A user reported a master crash when the following conditions were met:
1. The master tablet was enormous and took a while to bootstrap.
2. An external monitoring agent was periodically accessing the master's
/dump-entities URL.
While fixing this, I also double checked that the rest of the master URLs do
the right thing before making calls into the master.
The majority of the patch repurposes the PeriodicWebUIChecker (from
linked_list-test) for the new integration test. I modified its URL polling
behavior so that all URLs are polled before sleeping.
Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/master-path-handlers.cc
4 files changed, 41 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/4366/1
--
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] master: do not crash on /dump-entities during startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: master: do not crash on /dump-entities during startup
......................................................................
Patch Set 1: Code-Review+2
LGTM, presuming the new test failed without the fix
--
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] master: do not crash on /dump-entities during startup
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: master: do not crash on /dump-entities during startup
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3330/
--
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] master: do not crash on /dump-entities during startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: master: do not crash on /dump-entities during startup
......................................................................
master: do not crash on /dump-entities during startup
A user reported a master crash when the following conditions were met:
1. The master tablet was enormous and took a while to bootstrap.
2. An external monitoring agent was periodically accessing the master's
/dump-entities URL.
While fixing this, I also double checked that the rest of the master URLs do
the right thing before making calls into the master.
The majority of the patch repurposes the PeriodicWebUIChecker (from
linked_list-test) for the new integration test. I modified its URL polling
behavior so that all URLs are polled before sleeping.
Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Reviewed-on: http://gerrit.cloudera.org:8080/4366
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/master-path-handlers.cc
4 files changed, 41 insertions(+), 10 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] master: do not crash on /dump-entities during startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: master: do not crash on /dump-entities during startup
......................................................................
Patch Set 1:
tried the test without the fix locally, looks like it's a good one.
--
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No