You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 23:40:25 UTC
[GitHub] [airflow] jedcunningham commented on a change in pull request #21032: Add dev tool to review and classify cherry-picked commits
jedcunningham commented on a change in pull request #21032:
URL: https://github.com/apache/airflow/pull/21032#discussion_r792211814
##########
File path: dev/CHERRY_PICK_SUMMARY.txt.jinja2
##########
@@ -0,0 +1,27 @@
+---------------------------------------------------------
+
+This is summary of the cherry-picks:
+ Previous release: {{ previous_release }}
+ Current release: {{ current_release }}
+
+---------------------------------------------------------
+
+Changelog changes {{ changelog_changes | length }}:
+
+{% for change in changelog_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
+{%- endfor %}
+
+Doc only changes {{ doc_only_changes | length }}:
+
+{% for change in doc_only_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
Review comment:
```suggestion
* {{ change.short_hash }} : {{ change.message }} : http://github.com/apache/airflow/pull/{{ change.pr }}
```
##########
File path: dev/CHERRY_PICK_SUMMARY.txt.jinja2
##########
@@ -0,0 +1,27 @@
+---------------------------------------------------------
+
+This is summary of the cherry-picks:
+ Previous release: {{ previous_release }}
+ Current release: {{ current_release }}
+
+---------------------------------------------------------
+
+Changelog changes {{ changelog_changes | length }}:
+
+{% for change in changelog_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
+{%- endfor %}
+
+Doc only changes {{ doc_only_changes | length }}:
+
+{% for change in doc_only_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
+{%- endfor %}
+
+Excluded changes {{ excluded_changes | length }}:
+
+{% for change in excluded_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
Review comment:
```suggestion
* {{ change.short_hash }} : {{ change.message }} : http://github.com/apache/airflow/pull/{{ change.pr }}
```
##########
File path: dev/CHERRY_PICK_SUMMARY.txt.jinja2
##########
@@ -0,0 +1,27 @@
+---------------------------------------------------------
+
+This is summary of the cherry-picks:
+ Previous release: {{ previous_release }}
+ Current release: {{ current_release }}
+
+---------------------------------------------------------
+
+Changelog changes {{ changelog_changes | length }}:
+
+{% for change in changelog_changes %}
+ * {{ change.full_hash }} : {{ change.message }}
Review comment:
```suggestion
* {{ change.short_hash }} : {{ change.message }} : http://github.com/apache/airflow/pull/{{ change.pr }}
```
When going through the summary, I found clickable links really helpful.
Was `short_hash` not unique enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org