You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/10/05 11:09:38 UTC

Review Request 38994: Agent instance memory footprint likely gradually growing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38994/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13307
    https://issues.apache.org/jira/browse/AMBARI-13307


Repository: ambari


Description
-------


Diffs
-----

  ambari-common/src/main/python/resource_management/core/logger.py 7642c6d 

Diff: https://reviews.apache.org/r/38994/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 38994: Agent instance memory footprint likely gradually growing

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38994/#review101474
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/core/logger.py (line 41)
<https://reviews.apache.org/r/38994/#comment158869>

    The two returns do not return the same data. Is that OK? Also, it is possible for the second call to return before logger is properly initialized - before calls to setLevel/addHandler are called.


- Sumit Mohanty


On Oct. 5, 2015, 9:10 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38994/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 9:10 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13307
>     https://issues.apache.org/jira/browse/AMBARI-13307
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Noticed about 1.5 G of resident memory for the agents on a cluster that is running for about a month.
> Which is an obvious memory leak.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/logger.py 7642c6d 
> 
> Diff: https://reviews.apache.org/r/38994/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 38994: Agent instance memory footprint likely gradually growing

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38994/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 9:43 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13307
    https://issues.apache.org/jira/browse/AMBARI-13307


Repository: ambari


Description
-------

Noticed about 1.5 G of resident memory for the agents on a cluster that is running for about a month.
Which is an obvious memory leak.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/logger.py 7642c6d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py fc0428d 

Diff: https://reviews.apache.org/r/38994/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 38994: Agent instance memory footprint likely gradually growing

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38994/#review101455
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 5, 2015, 9:10 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38994/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 9:10 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13307
>     https://issues.apache.org/jira/browse/AMBARI-13307
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Noticed about 1.5 G of resident memory for the agents on a cluster that is running for about a month.
> Which is an obvious memory leak.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/logger.py 7642c6d 
> 
> Diff: https://reviews.apache.org/r/38994/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 38994: Agent instance memory footprint likely gradually growing

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38994/
-----------------------------------------------------------

(Updated Oct. 5, 2015, 9:10 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13307
    https://issues.apache.org/jira/browse/AMBARI-13307


Repository: ambari


Description (updated)
-------

Noticed about 1.5 G of resident memory for the agents on a cluster that is running for about a month.
Which is an obvious memory leak.


Diffs
-----

  ambari-common/src/main/python/resource_management/core/logger.py 7642c6d 

Diff: https://reviews.apache.org/r/38994/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk