You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Akshay Goyal <ak...@gmail.com> on 2015/05/19 19:12:39 UTC
Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-563
https://issues.apache.org/jira/browse/LENS-563
Repository: lens
Description
-------
Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
Diff: https://reviews.apache.org/r/34417/diff/
Testing
-------
Existing test cases passed.
Thanks,
Akshay Goyal
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/#review85163
-----------------------------------------------------------
Can you close this? This is already merged.
- Rajat Khandelwal
On May 22, 2015, 2:18 a.m., Akshay Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34417/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 2:18 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-563
> https://issues.apache.org/jira/browse/LENS-563
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1918e5c
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 5ea715d
>
> Diff: https://reviews.apache.org/r/34417/diff/
>
>
> Testing
> -------
>
> Existing test cases passed.
>
>
> Thanks,
>
> Akshay Goyal
>
>
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/
-----------------------------------------------------------
(Updated May 21, 2015, 8:48 p.m.)
Review request for lens.
Changes
-------
updated with latest changes
Bugs: LENS-563
https://issues.apache.org/jira/browse/LENS-563
Repository: lens
Description
-------
Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 1918e5c
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 5ea715d
Diff: https://reviews.apache.org/r/34417/diff/
Testing
-------
Existing test cases passed.
Thanks,
Akshay Goyal
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/
-----------------------------------------------------------
(Updated May 21, 2015, 10:42 a.m.)
Review request for lens.
Changes
-------
review changes for doc
Bugs: LENS-563
https://issues.apache.org/jira/browse/LENS-563
Repository: lens
Description
-------
Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 06f85ee
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
Diff: https://reviews.apache.org/r/34417/diff/
Testing
-------
Existing test cases passed.
Thanks,
Akshay Goyal
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/#review84495
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/34417/#comment135809>
Won't it be `cube.fact.{fact-name}.valid.columns.size` together with `cube.fact.{fact-name}.valid.columns{i}` for `0<= i < size` ?
- Rajat Khandelwal
On May 20, 2015, 10:45 a.m., Akshay Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34417/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 10:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-563
> https://issues.apache.org/jira/browse/LENS-563
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 06f85ee
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
>
> Diff: https://reviews.apache.org/r/34417/diff/
>
>
> Testing
> -------
>
> Existing test cases passed.
>
>
> Thanks,
>
> Akshay Goyal
>
>
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/
-----------------------------------------------------------
(Updated May 20, 2015, 5:15 a.m.)
Review request for lens.
Bugs: LENS-563
https://issues.apache.org/jira/browse/LENS-563
Repository: lens
Description
-------
Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 06f85ee
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
Diff: https://reviews.apache.org/r/34417/diff/
Testing
-------
Existing test cases passed.
Thanks,
Akshay Goyal
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/#review84461
-----------------------------------------------------------
Ship it!
lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/34417/#comment135751>
Seems we need to set cube.fact.{fact-name}.valid.columns.size as well.
Can you update doc accordingly?
- Amareshwari Sriramadasu
On May 20, 2015, 4:30 a.m., Akshay Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34417/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-563
> https://issues.apache.org/jira/browse/LENS-563
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 06f85ee
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
>
> Diff: https://reviews.apache.org/r/34417/diff/
>
>
> Testing
> -------
>
> Existing test cases passed.
>
>
> Thanks,
>
> Akshay Goyal
>
>
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/
-----------------------------------------------------------
(Updated May 20, 2015, 4:30 a.m.)
Review request for lens.
Changes
-------
Updated cube-0.1.xsd
Bugs: LENS-563
https://issues.apache.org/jira/browse/LENS-563
Repository: lens
Description
-------
Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 06f85ee
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
Diff: https://reviews.apache.org/r/34417/diff/
Testing
-------
Existing test cases passed.
Thanks,
Akshay Goyal
Re: Review Request 34417: LENS-563: Accepting valid columns of length
more than 4000 for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34417/#review84452
-----------------------------------------------------------
Can you update cube-0.1.xsd as well - to say if valid columns property value length exceeds 3999, it should be passed as property[0-N], each with max 3999 length string?
- Amareshwari Sriramadasu
On May 19, 2015, 5:12 p.m., Akshay Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34417/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:12 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-563
> https://issues.apache.org/jira/browse/LENS-563
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently, lens accept valid column names of a fact through a property - upto length of 4000. We need to support valid columns of length more than this.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 9daccec
>
> Diff: https://reviews.apache.org/r/34417/diff/
>
>
> Testing
> -------
>
> Existing test cases passed.
>
>
> Thanks,
>
> Akshay Goyal
>
>