You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2016/09/12 14:31:30 UTC

[1/4] lucene-solr:master: LUCENE-7442: MinHashFilter's ctor should validate its args

Repository: lucene-solr
Updated Branches:
  refs/heads/branch_6_2 c7b3e9ae3 -> 8066a3605
  refs/heads/branch_6x 1b03c9403 -> 6fb22fcf5
  refs/heads/master f177a660f -> 36362a2a6


LUCENE-7442: MinHashFilter's ctor should validate its args


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/36362a2a
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/36362a2a
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/36362a2a

Branch: refs/heads/master
Commit: 36362a2a69a30918d1f6670af208a0801909304f
Parents: f177a66
Author: Steve Rowe <sa...@apache.org>
Authored: Mon Sep 12 10:18:29 2016 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Mon Sep 12 10:18:29 2016 -0400

----------------------------------------------------------------------
 lucene/CHANGES.txt                                          | 3 +++
 .../org/apache/lucene/analysis/minhash/MinHashFilter.java   | 9 +++++++++
 2 files changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/36362a2a/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 4f5326b..453e6cb 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -53,6 +53,9 @@ Bug Fixes
   ArrayIndexOutOfBoundsException exception on large index segments (>1.8B docs)
   with large skips. (yonik)
 
+* LUCENE-7442: MinHashFilter's ctor should validate its args.
+  (Cao Manh Dat via Steve Rowe)
+
 Improvements
 
 Optimizations

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/36362a2a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
----------------------------------------------------------------------
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
index 772f58a..4ddf711 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
@@ -114,6 +114,15 @@ public class MinHashFilter extends TokenFilter {
    */
   public MinHashFilter(TokenStream input, int hashCount, int bucketCount, int hashSetSize, boolean withRotation) {
     super(input);
+    if (hashCount <= 0) {
+      throw new IllegalArgumentException("hashCount must be greater than zero");
+    }
+    if (bucketCount <= 0) {
+      throw new IllegalArgumentException("bucketCount must be greater than zero");
+    }
+    if (hashSetSize <= 0) {
+      throw new IllegalArgumentException("hashSetSize must be greater than zero");
+    }
     this.hashCount = hashCount;
     this.bucketCount = bucketCount;
     this.hashSetSize = hashSetSize;


[4/4] lucene-solr:branch_6_2: LUCENE-7442: add changes entry for 6.2.1

Posted by sa...@apache.org.
LUCENE-7442: add changes entry for 6.2.1


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8066a360
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8066a360
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8066a360

Branch: refs/heads/branch_6_2
Commit: 8066a3605ccf4b91ece20810fd435f1b5c6da44f
Parents: 109ec23
Author: Steve Rowe <sa...@apache.org>
Authored: Mon Sep 12 10:30:48 2016 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Mon Sep 12 10:30:48 2016 -0400

----------------------------------------------------------------------
 lucene/CHANGES.txt | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8066a360/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index f62e470..db7fe20 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -20,6 +20,9 @@ Bug Fixes
   ArrayIndexOutOfBoundsException exception on large index segments (>1.8B docs)
   with large skips. (yonik)
 
+* LUCENE-7442: MinHashFilter's ctor should validate its args.
+  (Cao Manh Dat via Steve Rowe)
+
 ======================= Lucene 6.2.0 =======================
 
 API Changes


[2/4] lucene-solr:branch_6x: LUCENE-7442: MinHashFilter's ctor should validate its args

Posted by sa...@apache.org.
LUCENE-7442: MinHashFilter's ctor should validate its args


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/6fb22fcf
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/6fb22fcf
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/6fb22fcf

Branch: refs/heads/branch_6x
Commit: 6fb22fcf55ce2883f45da285ee97a05e7a832579
Parents: 1b03c94
Author: Steve Rowe <sa...@apache.org>
Authored: Mon Sep 12 10:18:29 2016 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Mon Sep 12 10:18:59 2016 -0400

----------------------------------------------------------------------
 lucene/CHANGES.txt                                          | 3 +++
 .../org/apache/lucene/analysis/minhash/MinHashFilter.java   | 9 +++++++++
 2 files changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6fb22fcf/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index dae94b5..da625c5 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -22,6 +22,9 @@ Bug Fixes
   ArrayIndexOutOfBoundsException exception on large index segments (>1.8B docs)
   with large skips. (yonik)
 
+* LUCENE-7442: MinHashFilter's ctor should validate its args.
+  (Cao Manh Dat via Steve Rowe)
+
 Improvements
 
 Optimizations

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6fb22fcf/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
----------------------------------------------------------------------
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
index 772f58a..4ddf711 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
@@ -114,6 +114,15 @@ public class MinHashFilter extends TokenFilter {
    */
   public MinHashFilter(TokenStream input, int hashCount, int bucketCount, int hashSetSize, boolean withRotation) {
     super(input);
+    if (hashCount <= 0) {
+      throw new IllegalArgumentException("hashCount must be greater than zero");
+    }
+    if (bucketCount <= 0) {
+      throw new IllegalArgumentException("bucketCount must be greater than zero");
+    }
+    if (hashSetSize <= 0) {
+      throw new IllegalArgumentException("hashSetSize must be greater than zero");
+    }
     this.hashCount = hashCount;
     this.bucketCount = bucketCount;
     this.hashSetSize = hashSetSize;


[3/4] lucene-solr:branch_6_2: LUCENE-7442: MinHashFilter's ctor should validate its args

Posted by sa...@apache.org.
LUCENE-7442: MinHashFilter's ctor should validate its args


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/109ec234
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/109ec234
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/109ec234

Branch: refs/heads/branch_6_2
Commit: 109ec23426d6d42c7cefd10ad96a56ca504e6a9a
Parents: c7b3e9a
Author: Steve Rowe <sa...@apache.org>
Authored: Mon Sep 12 10:18:29 2016 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Mon Sep 12 10:30:00 2016 -0400

----------------------------------------------------------------------
 .../org/apache/lucene/analysis/minhash/MinHashFilter.java   | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/109ec234/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
----------------------------------------------------------------------
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
index 772f58a..4ddf711 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/minhash/MinHashFilter.java
@@ -114,6 +114,15 @@ public class MinHashFilter extends TokenFilter {
    */
   public MinHashFilter(TokenStream input, int hashCount, int bucketCount, int hashSetSize, boolean withRotation) {
     super(input);
+    if (hashCount <= 0) {
+      throw new IllegalArgumentException("hashCount must be greater than zero");
+    }
+    if (bucketCount <= 0) {
+      throw new IllegalArgumentException("bucketCount must be greater than zero");
+    }
+    if (hashSetSize <= 0) {
+      throw new IllegalArgumentException("hashSetSize must be greater than zero");
+    }
     this.hashCount = hashCount;
     this.bucketCount = bucketCount;
     this.hashSetSize = hashSetSize;