[jira] [Closed] (OFBIZ-5544) The getFeatureIdQtyMap function doesn't include the DISTINGUISHING_FEAT into the featureMap

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5544.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 13.07
                   Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
         Assignee: Jacques Le Roux

Hi Praven,

Your modified patch is committed in
trunk r1571219
R13.07 r1571225
R12.04 r1571226
R11.04 r1571227

When the amount is null it's now not added in the adjustement (I moved that in the block above where the amount is already tested for null). But the OrderAdjustment is still created because a recurringAmount could still exist . I just added a warning for when both amounts are null. We could decide to not create an adjustement when there are no amounts at all. But I preferred a warning, because it's a weird situation and people could prefer to be aware...


> The getFeatureIdQtyMap function doesn't include the DISTINGUISHING_FEAT into the featureMap
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5544
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5544
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Praveen Agrawal
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: OFBiz-5544.patch
>
>
> The getFeatureIdQtyMap function in ShoppingCartItem.java doesn't include the DISTINGUISHING_FEAT in featureMap so if we want to calculate the Shipping amount based on Distinguishing feature, this method doesn't return the Distinguishing Feature in Feature Map.
> If we add DISTINGUISHING_FEAT as productFeatureApplTypeId in filterExprs then the feature map would contain the Distinguishing feature in addition to Standard and Required Feature.
> Also in ShoppingCartItem.java, putAdditionalProductFeatureAndAppl method, i think the OrderAdjustment should only be included when the amount is not null.
> The above issues are exists in all other branches including Trunk



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)