[jira] [Commented] (WICKET-4803) UrlDecoder should log a message when invalid input is provided

["Jan Riehn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582062#comment-13582062 ] 

Jan Riehn commented on WICKET-4803:
-----------------------------------

Hej Martin,

this is also my preferred solution. Thank you!

Regards,

Jan
                
> UrlDecoder should log a message when invalid input is provided
> --------------------------------------------------------------
>
>                 Key: WICKET-4803
>                 URL: https://issues.apache.org/jira/browse/WICKET-4803
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.8, 6.5.0
>            Reporter: Johan Heylen
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 6.7.0, 1.5.10
>
>         Attachments: WICKET-4803-quickstart-testcase-and-example.zip
>
>
> In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException, otherwise they are caught by the exception handler form the servlet container (jetty, tomcat, ...) which then uses their http 500 error code configuration instead of the exception handling of wicket.
> Wrapping them would be good for consistency and help manage runtime exceptions. 
> These are the two exceptions:
> throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern"); 
> throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage()); 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira