You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/30 15:04:32 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Baoyuantop opened a new pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
According to the latest `schema.json`, add `nodelay` options to `limit-req` plugin.
**Related issues**
fix #2015
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-892498710
@liuxiran @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889966326
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2021](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bdce3b7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `3.86%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head bdce3b7 differs from pull request most recent head 8ca9624. Consider uploading reports for the commit 8ca9624 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
- Coverage 67.92% 64.05% -3.87%
==========================================
Files 182 122 -60
Lines 6972 3158 -3814
Branches 753 754 +1
==========================================
- Hits 4736 2023 -2713
+ Misses 1949 1135 -814
+ Partials 287 0 -287
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.05% <100.00%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ø)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
| [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
| [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | | |
| [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | |
| ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33c735e...8ca9624](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 3ae3781185581db1bdf5333ff9597d34f145d2d9
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6104f50be7d6370007f71e2d](https://app.netlify.com/sites/apisix-dashboard/deploys/6104f50be7d6370007f71e2d?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2021--apisix-dashboard.netlify.app/](https://deploy-preview-2021--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889966326
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2021](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (881a0bd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `3.82%`.
> The diff coverage is `72.72%`.
> :exclamation: Current head 881a0bd differs from pull request most recent head 3ae3781. Consider uploading reports for the commit 3ae3781 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
- Coverage 67.92% 64.10% -3.83%
==========================================
Files 182 122 -60
Lines 6972 3165 -3807
Branches 753 758 +5
==========================================
- Hits 4736 2029 -2707
+ Misses 1949 1136 -813
+ Partials 287 0 -287
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.10% <72.72%> (+0.15%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `66.04% <56.25%> (+0.44%)` | :arrow_up: |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <91.66%> (+0.72%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ø)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
| [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
| [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
| ... and [55 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...3ae3781](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#discussion_r680511490
##########
File path: web/src/components/Plugin/UI/limit-req.tsx
##########
@@ -88,10 +95,21 @@ const LimitReq: React.FC<Props> = ({ form, schema }) => {
initialValue={propertires.rejected_code.default}
tooltip={formatMessage({ id: 'component.pluginForm.limit-req.rejected_code.tooltip' })}
>
- <InputNumber min={propertires.rejected_code.minimum} max={propertires.rejected_code.maximum} />
+ <InputNumber
+ min={propertires.rejected_code.minimum}
+ max={propertires.rejected_code.maximum}
+ />
+ </Form.Item>
+ <Form.Item
Review comment:
maybe, because `husky` is introduced days ago, and don't have a global lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 434ed69f6afdf0b6f664a57f7d622ea55d3babf7
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cc3ede5a91a0008ffb52b](https://app.netlify.com/sites/apisix-dashboard/deploys/610cc3ede5a91a0008ffb52b?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2021--apisix-dashboard.netlify.app/](https://deploy-preview-2021--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-892537139
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 434ed69f6afdf0b6f664a57f7d622ea55d3babf7
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cc3ede5a91a0008ffb52b](https://app.netlify.com/sites/apisix-dashboard/deploys/610cc3ede5a91a0008ffb52b?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#discussion_r680501894
##########
File path: web/src/components/Plugin/UI/limit-req.tsx
##########
@@ -88,10 +95,21 @@ const LimitReq: React.FC<Props> = ({ form, schema }) => {
initialValue={propertires.rejected_code.default}
tooltip={formatMessage({ id: 'component.pluginForm.limit-req.rejected_code.tooltip' })}
>
- <InputNumber min={propertires.rejected_code.minimum} max={propertires.rejected_code.maximum} />
+ <InputNumber
+ min={propertires.rejected_code.minimum}
+ max={propertires.rejected_code.maximum}
+ />
+ </Form.Item>
+ <Form.Item
Review comment:
when I `commit` code, the `lint-staged` is executed, then the code becomes like this.
Does it seem that too much code was not executed by `lint-staged` before?🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 8ca96240487cc0f472d71ff9977249ed02ab28a8
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610414f57bfb86000794b589](https://app.netlify.com/sites/apisix-dashboard/deploys/610414f57bfb86000794b589?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: e84c865f7e02d530c70fafba7705f02323e0fdda
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61095869c2eef70007ebde63](https://app.netlify.com/sites/apisix-dashboard/deploys/61095869c2eef70007ebde63?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: e84c865f7e02d530c70fafba7705f02323e0fdda
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61095869c2eef70007ebde63](https://app.netlify.com/sites/apisix-dashboard/deploys/61095869c2eef70007ebde63?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2021--apisix-dashboard.netlify.app/](https://deploy-preview-2021--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889966326
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2021](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (434ed69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/af855915896562c488c2b4669e24883cd140cfb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af85591) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
+ Coverage 63.52% 63.58% +0.06%
==========================================
Files 121 121
Lines 3213 3213
Branches 779 779
==========================================
+ Hits 2041 2043 +2
+ Misses 1172 1170 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `63.58% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <ø> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [af85591...434ed69](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 8ca96240487cc0f472d71ff9977249ed02ab28a8
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610414f57bfb86000794b589](https://app.netlify.com/sites/apisix-dashboard/deploys/610414f57bfb86000794b589?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2021--apisix-dashboard.netlify.app/](https://deploy-preview-2021--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889953863
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 3ae3781185581db1bdf5333ff9597d34f145d2d9
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6104f50be7d6370007f71e2d](https://app.netlify.com/sites/apisix-dashboard/deploys/6104f50be7d6370007f71e2d?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#discussion_r680485384
##########
File path: web/src/components/Plugin/UI/limit-req.tsx
##########
@@ -88,10 +95,21 @@ const LimitReq: React.FC<Props> = ({ form, schema }) => {
initialValue={propertires.rejected_code.default}
tooltip={formatMessage({ id: 'component.pluginForm.limit-req.rejected_code.tooltip' })}
>
- <InputNumber min={propertires.rejected_code.minimum} max={propertires.rejected_code.maximum} />
+ <InputNumber
+ min={propertires.rejected_code.minimum}
+ max={propertires.rejected_code.maximum}
+ />
+ </Form.Item>
+ <Form.Item
Review comment:
@Baoyuantop I notice this PR's main change is here, and other changes are made by your IDE or some other tools? They confuse me when I review your PR, please don't change them in this PR.
BTW, please test this new field, you could ask @guoqqqi for help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-889966326
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2021](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d989260) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `3.86%`.
> The diff coverage is `72.72%`.
> :exclamation: Current head d989260 differs from pull request most recent head e84c865. Consider uploading reports for the commit e84c865 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
- Coverage 67.92% 64.06% -3.87%
==========================================
Files 182 121 -61
Lines 6972 3161 -3811
Branches 753 757 +4
==========================================
- Hits 4736 2025 -2711
+ Misses 1949 1136 -813
+ Partials 287 0 -287
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.06% <72.72%> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <ø> (-3.34%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `66.04% <56.25%> (+0.44%)` | :arrow_up: |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <91.66%> (+0.72%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ø)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | |
| ... and [56 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2021/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...e84c865](https://codecov.io/gh/apache/apisix-dashboard/pull/2021?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-891163220
looking forward to your test case, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2021: fix(Plugin): add nodelay for limit-req plugin
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2021:
URL: https://github.com/apache/apisix-dashboard/pull/2021#issuecomment-892537139
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org