You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/21 09:33:27 UTC

[GitHub] [tvm] chiwwang opened a new pull request #10333: [Relay] Fix TFlite frontend for unpack, stridedslice

chiwwang opened a new pull request #10333:
URL: https://github.com/apache/tvm/pull/10333


   We found this while converting an RNN model.
   
   The relay tflite frontend use squeeze at converting unpack, but when the
   unpack.axis=0, `None` is passed to relay.squeeze(), which would squeeze
   all dimensions with length 1, causing different results from TFLite.
   
   A possible fix might be, assign the unpack.axis as-is to relay.squeeze()
   
   As for stridedslice, when the tflite frontend handles shrink_axis_mask,
   the wrapped `begin` should be used, instead of the original one which
   can be negative. It can cause errors at
   https://github.com/apache/tvm/blob/d65ff6594d4d6db0062537a1d43c0504173b8e5c/include/tvm/topi/detail/strided_slice.h#L140
   
   Related cases are also added to the python test.
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #10333: [Relay] Fix TFlite frontend for unpack, stridedslice

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10333:
URL: https://github.com/apache/tvm/pull/10333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org