[GitHub] [superset] robdiciuccio commented on pull request #16412: fix: Support Jinja template functions in global async queries

[GitBox <gi...@apache.org>]

robdiciuccio commented on pull request #16412:
URL: https://github.com/apache/superset/pull/16412#issuecomment-906636569


   @craig-rueda there is test coverage for using `g.form_data` [here](https://github.com/preset-io/superset/blob/rd/jinja-async-queries/tests/integration_tests/utils_tests.py#L992:L992). Flask `has_request_context` doesn't work properly in tests, apparently due to `flask._preserve_context` being enabled in `test_client()`, and mocking it doesn't work either. ¯\_(ツ)_/¯


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org