You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Wang1rrr (via GitHub)" <gi...@apache.org> on 2026/10/19 03:05:33 UTC
[PR] fix(ai): bound partial SSE frames after draining complete events [rocketmq-dashboard]
Wang1rrr opened a new pull request, #6976:
URL: https://github.com/apache/rocketmq-dashboard/pull/6976
### Which Issue(s) This PR Fixes
Fixes #6974.
### Brief Description
Check the unterminated SSE remainder after draining complete frames from each network chunk. Previously, a heartbeat or agent frame before an oversized partial event caused the initial guard to skip the size check; the oversized remainder then waited for another read or the idle timeout.
Complete frames retain their existing individual size checks. A large network chunk containing several individually bounded events is still accepted.
### How Did You Test This Change?
- Added regressions for oversized remainders following a heartbeat and an agent frame in the same chunk. Both fail on the original reader because rejection is delayed until the idle timeout.
- Added a passing case for a chunk over 1 MiB containing two valid frames plus `done`.
- `npx vitest run src/api/ai.test.ts`: 37 tests passed.
- Targeted ESLint and `npx tsc -b`: passed.
### Checklist
- [x] One coherent defect fix with a conventional commit.
- [x] New regression cases end in `Test`.
- [x] No new dependencies or UI text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ai): bound partial SSE frames after draining complete events [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6976:
URL: https://github.com/apache/rocketmq-dashboard/pull/6976#issuecomment-6433479972
Merged as part of #6998 - squashed into `rocketmq-studio` as `1053cd4be`.
Your change here (apply the SSE size limit after complete events are drained, so only the unfinished remainder is bounded) is included.
We grouped 8 of your related AI conversation fixes into a single commit so the history stays reviewable; the other PRs in the group are closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change.
Thanks for the consistently well-tested patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ai): bound partial SSE frames after draining complete events [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6976: fix(ai): bound partial SSE frames after draining complete events
URL: https://github.com/apache/rocketmq-dashboard/pull/6976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org