You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/17 00:53:28 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7843: DNS: Fix lack of nameserver failover in low use circumstances.

maskit commented on a change in pull request #7843:
URL: https://github.com/apache/trafficserver/pull/7843#discussion_r633166216



##########
File path: iocore/dns/DNS.cc
##########
@@ -766,6 +766,8 @@ DNSHandler::failover()
     ip_text_buffer buff;
     Warning("failover: connection to DNS server %s lost, retrying", ats_ip_ntop(&ip.sa, buff, sizeof(buff)));
   }
+  // Make sure retries are done even if no more requests.
+  this_ethread()->schedule_at(this, DNS_PRIMARY_RETRY_PERIOD);

Review comment:
       Shouldn't it be `schedule_in`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org