You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/27 18:20:14 UTC
[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #2969: change the logic of requester list verification
arjun4084346 opened a new pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969
codestyle changes
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416356645
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId, EmptyRecord> key) {
* @param originalFlowConfig original flow config to find original requester
* @param requesterList list of requesters for this request
*/
- public static void checkRequester(FlowConfig originalFlowConfig, List<ServiceRequester> requesterList) {
Review comment:
Had to change it, coz using non static object (this.requesterService) inside.
Will work actively towards removing V1 completely
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416357858
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId, EmptyRecord> key) {
* @param originalFlowConfig original flow config to find original requester
* @param requesterList list of requesters for this request
*/
- public static void checkRequester(FlowConfig originalFlowConfig, List<ServiceRequester> requesterList) {
Review comment:
You could pass the requesterservice as an argument. But sure, I guess having the duplication is fine if we're probably not going to make changes to v1 after this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416356645
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId, EmptyRecord> key) {
* @param originalFlowConfig original flow config to find original requester
* @param requesterList list of requesters for this request
*/
- public static void checkRequester(FlowConfig originalFlowConfig, List<ServiceRequester> requesterList) {
Review comment:
Had to change it, coz using non static object (this.requesterService) inside.
Will work actively towards deprecating V1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#issuecomment-620168499
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=h1) Report
> Merging [#2969](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d8d579a42ec901dd74b6f453bd334c77e9498195&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `17.85%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2969 +/- ##
============================================
- Coverage 45.64% 45.63% -0.02%
- Complexity 9197 9198 +1
============================================
Files 1940 1940
Lines 73574 73581 +7
Branches 8128 8128
============================================
- Hits 33586 33577 -9
- Misses 36864 36880 +16
Partials 3124 3124
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ce/extractor/extract/restapi/RestApiConnector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9yZXN0YXBpL1Jlc3RBcGlDb25uZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/service/FlowConfigsResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1Jlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/gobblin/service/NoopRequesterService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Ob29wUmVxdWVzdGVyU2VydmljZS5qYXZh) | `50.00% <0.00%> (-16.67%)` | `1.00 <0.00> (ø)` | |
| [...apache/gobblin/salesforce/SalesforceConnector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUNvbm5lY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/service/RequesterService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9SZXF1ZXN0ZXJTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `4.00 <1.00> (ø)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `43.68% <0.00%> (-5.83%)` | `12.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `34.92% <0.00%> (-5.56%)` | `14.00% <0.00%> (-2.00%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `79.43% <0.00%> (-0.94%)` | `24.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `67.53% <0.00%> (-0.38%)` | `33.00% <0.00%> (ø%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=footer). Last update [d8d579a...1b6c9b5](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416683094
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java
##########
@@ -50,22 +55,27 @@ public RequesterService(Config config) {
*/
public static String serialize(List<ServiceRequester> requesterList) throws IOException {
String jsonList = objectMapper.writeValueAsString(requesterList);
- String base64Str = Base64.getEncoder().encodeToString(jsonList.getBytes("UTF-8"));
- return URLEncoder.encode(base64Str, "UTF-8");
+ String base64Str = Base64.getEncoder().encodeToString(jsonList.getBytes(StandardCharsets.UTF_8));
+ return URLEncoder.encode(base64Str, StandardCharsets.UTF_8.name());
}
/**
* <p> This implementation decode a given string encoded by
* {@link #serialize(List)}.
*/
public static List<ServiceRequester> deserialize(String encodedString) throws IOException {
- String base64Str = URLDecoder.decode(encodedString, "UTF-8");
+ String base64Str = URLDecoder.decode(encodedString, StandardCharsets.UTF_8.name());
byte[] decodedBytes = Base64.getDecoder().decode(base64Str);
- String jsonList = new String(decodedBytes, "UTF-8");
+ String jsonList = new String(decodedBytes, StandardCharsets.UTF_8);
TypeReference<List<ServiceRequester>> mapType = new TypeReference<List<ServiceRequester>>() {};
- List<ServiceRequester> requesterList = objectMapper.readValue(jsonList, mapType);
- return requesterList;
+ return objectMapper.readValue(jsonList, mapType);
}
protected abstract List<ServiceRequester> findRequesters(BaseResource resource);
+
+ /**
+ * This method should throw {@link FlowConfigLoggedException}, if the requester is not allowed to make this request.
+ */
+ protected abstract void requesterAllowed(List<ServiceRequester> originalRequesterList,
Review comment:
How about now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416356498
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java
##########
@@ -50,22 +55,27 @@ public RequesterService(Config config) {
*/
public static String serialize(List<ServiceRequester> requesterList) throws IOException {
String jsonList = objectMapper.writeValueAsString(requesterList);
- String base64Str = Base64.getEncoder().encodeToString(jsonList.getBytes("UTF-8"));
- return URLEncoder.encode(base64Str, "UTF-8");
+ String base64Str = Base64.getEncoder().encodeToString(jsonList.getBytes(StandardCharsets.UTF_8));
+ return URLEncoder.encode(base64Str, StandardCharsets.UTF_8.name());
}
/**
* <p> This implementation decode a given string encoded by
* {@link #serialize(List)}.
*/
public static List<ServiceRequester> deserialize(String encodedString) throws IOException {
- String base64Str = URLDecoder.decode(encodedString, "UTF-8");
+ String base64Str = URLDecoder.decode(encodedString, StandardCharsets.UTF_8.name());
byte[] decodedBytes = Base64.getDecoder().decode(base64Str);
- String jsonList = new String(decodedBytes, "UTF-8");
+ String jsonList = new String(decodedBytes, StandardCharsets.UTF_8);
TypeReference<List<ServiceRequester>> mapType = new TypeReference<List<ServiceRequester>>() {};
- List<ServiceRequester> requesterList = objectMapper.readValue(jsonList, mapType);
- return requesterList;
+ return objectMapper.readValue(jsonList, mapType);
}
protected abstract List<ServiceRequester> findRequesters(BaseResource resource);
+
+ /**
+ * This method should throw {@link FlowConfigLoggedException}, if the requester is not allowed to make this request.
+ */
+ protected abstract void requesterAllowed(List<ServiceRequester> originalRequesterList,
Review comment:
Maybe call this isRequesterAllowed and make it return boolean?
I know I made the original checkRequester throw exception, but this one's only called from one place and is abstract, so it seems better to have a more clear contract of returning boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #2969: change the logic of requester list verification
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#issuecomment-620168499
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=h1) Report
> Merging [#2969](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d8d579a42ec901dd74b6f453bd334c77e9498195&el=desc) will **decrease** coverage by `0.94%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2969 +/- ##
============================================
- Coverage 45.64% 44.70% -0.95%
+ Complexity 9197 9026 -171
============================================
Files 1940 1940
Lines 73574 73573 -1
Branches 8128 8128
============================================
- Hits 33586 32888 -698
- Misses 36864 37601 +737
+ Partials 3124 3084 -40
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ce/extractor/extract/restapi/RestApiConnector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9yZXN0YXBpL1Jlc3RBcGlDb25uZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/service/FlowConfigsResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1Jlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/gobblin/salesforce/SalesforceConnector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUNvbm5lY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/service/RequesterService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9SZXF1ZXN0ZXJTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `4.00 <1.00> (ø)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `0.00% <0.00%> (-80.77%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2969/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=footer). Last update [d8d579a...f138d6f](https://codecov.io/gh/apache/incubator-gobblin/pull/2969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416354511
##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId, EmptyRecord> key) {
* @param originalFlowConfig original flow config to find original requester
* @param requesterList list of requesters for this request
*/
- public static void checkRequester(FlowConfig originalFlowConfig, List<ServiceRequester> requesterList) {
Review comment:
Why not leave this as static to avoid code duplication? You could move it to FlowConfigsV2Resource if you're considering that FlowConfigsResource may be removed eventually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org