You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 08:53:41 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
jorgecarleitao opened a new pull request #8851:
URL: https://github.com/apache/arrow/pull/8851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-739474986
This is awaiting #8849 to build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-741981026
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=h1) Report
> Merging [#8851](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=desc) (bda962c) into [master](https://codecov.io/gh/apache/arrow/commit/38cfdc3c95c0066b7b6a9b7fb5a47494decf7805?el=desc) (38cfdc3) will **increase** coverage by `1.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8851 +/- ##
==========================================
+ Coverage 52.92% 54.63% +1.70%
==========================================
Files 172 178 +6
Lines 30710 31270 +560
==========================================
+ Hits 16253 17084 +831
+ Misses 14457 14186 -271
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `0.00% <0.00%> (-76.86%)` | :arrow_down: |
| [rust/arrow/src/array/transform/null.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL251bGwucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/arrow/src/array/cast.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvY2FzdC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/array/equal/decimal.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvZGVjaW1hbC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/limit.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2xpbWl0LnJz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/array/equal/fixed\_list.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvZml4ZWRfbGlzdC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/length.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2xlbmd0aC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/array/transform/primitive.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ByaW1pdGl2ZS5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=footer). Last update [38cfdc3...bda962c](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-739475320
https://issues.apache.org/jira/browse/ARROW-10825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-741981026
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=h1) Report
> Merging [#8851](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=desc) (8cee9b0) into [master](https://codecov.io/gh/apache/arrow/commit/1ecef42bb9fb9e91f0fb04c7d5a1c3be58390025?el=desc) (1ecef42) will **increase** coverage by `0.00%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8851 +/- ##
=======================================
Coverage 82.65% 82.66%
=======================================
Files 200 201 +1
Lines 49795 49812 +17
=======================================
+ Hits 41159 41175 +16
- Misses 8636 8637 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/transform/null.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL251bGwucnM=) | `66.66% <66.66%> (ø)` | |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `87.30% <100.00%> (+0.12%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.32% <0.00%> (+0.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=footer). Last update [1ecef42...8cee9b0](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-741981026
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=h1) Report
> Merging [#8851](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=desc) (e19e891) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.00%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8851 +/- ##
=======================================
Coverage 82.61% 82.62%
=======================================
Files 202 203 +1
Lines 50048 50065 +17
=======================================
+ Hits 41347 41364 +17
Misses 8701 8701
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/transform/null.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL251bGwucnM=) | `66.66% <66.66%> (ø)` | |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `88.29% <100.00%> (+0.09%)` | :arrow_up: |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/8851/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.32% <0.00%> (+0.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=footer). Last update [51672b2...e19e891](https://codecov.io/gh/apache/arrow/pull/8851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8851:
URL: https://github.com/apache/arrow/pull/8851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8851:
URL: https://github.com/apache/arrow/pull/8851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8851: ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8851:
URL: https://github.com/apache/arrow/pull/8851#issuecomment-752956134
The full set of Rust CI tests did not run on this PR :(
Can you please rebase this PR against [apache/master](https://github.com/apache/arrow) to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do?
I apologize for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org