You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by marijan milicevic <m....@onehippo.com> on 2012/01/08 15:36:57 UTC
Review Request: Use bcrypt for password hashing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3428/
-----------------------------------------------------------
Review request for rave.
Summary
-------
https://issues.apache.org/jira/browse/RAVE-410
Diffs
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultNewAccountServiceTest.java 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/test_data.sql 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1228831
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1228831
Diff: https://reviews.apache.org/r/3428/diff
Testing
-------
Thanks,
marijan
Re: Review Request: Use bcrypt for password hashing
Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3428/#review4269
-----------------------------------------------------------
Ship it!
I'll commit later today if there are no more reviews.
- Marlon
On 2012-01-08 14:36:57, marijan milicevic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3428/
> -----------------------------------------------------------
>
> (Updated 2012-01-08 14:36:57)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/RAVE-410
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultNewAccountServiceTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/test_data.sql 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1228831
>
> Diff: https://reviews.apache.org/r/3428/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> marijan
>
>
Re: Review Request: Use bcrypt for password hashing
Posted by mf...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3428/#review4266
-----------------------------------------------------------
Ship it!
Code changes look good
- mfranklin
On 2012-01-08 14:36:57, marijan milicevic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3428/
> -----------------------------------------------------------
>
> (Updated 2012-01-08 14:36:57)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/RAVE-410
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultNewAccountServiceTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/test_data.sql 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1228831
>
> Diff: https://reviews.apache.org/r/3428/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> marijan
>
>
Password database issue Re: Review Request: Use bcrypt for password
hashing
Posted by Marlon Pierce <ma...@iu.edu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I applied this patch, but note you may need to remove or manually update the persistent database (/tmp/rave_db.h2.db is the default) since stored password hashes will be different.
Marlon
On 1/8/12 9:36 AM, marijan milicevic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3428/
> -----------------------------------------------------------
>
> Review request for rave.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/RAVE-410
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaUserRepositoryTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultNewAccountServiceTest.java 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/test_data.sql 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1228831
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1228831
>
> Diff: https://reviews.apache.org/r/3428/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> marijan
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPDD7zAAoJEEfVXEODPFIDTsUIAI4IlyYRH6VAkP5YcYPpj46l
mNHGLOMphVG5V4OtHl9/A6NpG4d1XIZb+OtlkCskVlOUAiBZXrHvC/RBKHc+ao2f
lR3Ef3kuFCZ30fHH5HEpsMTDGW92OVwh+FRmd3tVe7EZjjOo+biGuvWNKf+YOdvX
JuqGiDMRJdJjtgF1yPO4ilgBe0Op0+WdWYVfiRkNhl5Ke2eo5KXX5C2mpUOPq8+b
m/CqxTaJm0fDS2xj4tY/6QyHNPhtD+PD8b95zFBc9CHYoE5JcVFe8B5HSluhkMzE
Db3iX3vmXpqKVzbnKmOTLxwtj5RlT+l/nlMHCryMB/x2Xckr9c2ZCFTAotRhGEQ=
=2wVM
-----END PGP SIGNATURE-----