[jira] [Commented] (MYNEWT-649) "newt target set" allows random variable to be set; should allow only valid variable settings.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042059#comment-16042059 ] 

ASF subversion and git services commented on MYNEWT-649:
--------------------------------------------------------

Commit c14fb5e79fdb1a617e50e2475ae82de6478d0e19 in incubator-mynewt-newt's branch refs/heads/master from [~ccollins476]
[ https://gitbox.apache.org/repos/asf?p=incubator-mynewt-newt.git;h=c14fb5e ]

This closes #65.

Merge remote-tracking branch 'cwanda/mynewt-649'

* cwanda/mynewt-649:
  Add space between required and optional variable setting in usage output.
  MYNEWT-649 Validate target variable target set command. Valid variables are: aflags, app, build_profile, bsp, cflags, lflags, loader, syscfg


> "newt target set" allows random variable to be set; should allow only valid variable settings.
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYNEWT-649
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-649
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>            Reporter: Aditi Hilbert
>            Assignee: Wanda Chiu
>             Fix For: v1_1_0_rel
>
>
> The "newt target set" command should have a check for allowed settings.
> For example, I can set the variable "bogus" with a value and  target.bogus will be added to the target.yml file.   Do we have a list of all the valid variables so we can add the validation to the command?  What I have listed as valid variables in the `newt target set" command documentation are: app, bsp, loader, build_profile, cflags, aflags, lflags, syscfg. 
> We should make sure the "newt vals" command also covers this set of valid target variables to make things consistent.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)