[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2322: Improve speed of writing string dictionaries to parquet by skipping a copy(#1764)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2322:
URL: https://github.com/apache/arrow-rs/pull/2322#discussion_r938715607


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -33,70 +33,18 @@ use super::schema::{
     decimal_length_from_precision,
 };
 
-use crate::column::writer::{get_column_writer, ColumnWriter, ColumnWriterImpl};
+use crate::arrow::arrow_writer::byte_array::ByteArrayWriter;
+use crate::column::writer::{ColumnWriter, ColumnWriterImpl};
 use crate::errors::{ParquetError, Result};
 use crate::file::metadata::RowGroupMetaDataPtr;
 use crate::file::properties::WriterProperties;
-use crate::file::writer::{SerializedColumnWriter, SerializedRowGroupWriter};
+use crate::file::writer::SerializedRowGroupWriter;
 use crate::{data_type::*, file::writer::SerializedFileWriter};
 use levels::{calculate_array_levels, LevelInfo};
 
 mod byte_array;
 mod levels;
 
-/// An object-safe API for writing an [`ArrayRef`]
-trait ArrayWriter {

Review Comment:
   I ended up implementing type erasure within the ByteArrayWriter, and so this indirection can be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org