[GitHub] jmark99 commented on issue #763: #708 Simplify API definition by moving impl packages from under API packages

[GitBox <gi...@apache.org>]

jmark99 commented on issue #763: #708 Simplify API definition by moving impl packages from under API packages
URL: https://github.com/apache/accumulo/pull/763#issuecomment-439397488
 
 
   Sorry about that! I thought I had a short header line with the PR number
   included. Not sure what happened there. That line was supposed to be the
   expanded explanation.
   
   On Thu, Nov 15, 2018 at 3:46 PM Christopher Tubbs <no...@github.com>
   wrote:
   
   > Looks like this was added as commit 2e892b3
   > <https://github.com/apache/accumulo/commit/2e892b3c8ec6b03912b9d82cacf3f5b1231200fa>
   > .
   > @jmark99 <https://github.com/jmark99> Next time, it'd be good idea to
   > reference the ticket number, or PR number, to make it obvious that it was
   > closed because it was merged, and not simply closed as aborted.
   >
   > Also, although too late now, it's generally a good idea to follow some
   > best practices for formatting the git commit log message... your first line
   > is a bit... long. Here's a good reference:
   > https://chris.beams.io/posts/git-commit/
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/accumulo/pull/763#issuecomment-439184121>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/AeHFYfxD3J8dX_DiwVbP34L1as2Mb08Pks5uvdKhgaJpZM4YchKv>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services