You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fox (JIRA)" <ji...@apache.org> on 2011/07/15 18:05:00 UTC
[jira] [Created] (TORQUE-167) Remove the filed
Criteria.Criterion.db
Remove the filed Criteria.Criterion.db
--------------------------------------
Key: TORQUE-167
URL: https://issues.apache.org/jira/browse/TORQUE-167
Project: Torque
Issue Type: Improvement
Components: Runtime
Reporter: Thomas Fox
Assignee: Thomas Fox
The db field of the Criterion specifies which database dialect is used for rendering this Criterion in SQL.
In my opinion the database dialect should be determined from a criteria field, not from any nested object.
Implications:
As a criterion is no standalone class, but an inner class of a Criteria, it always has a criteria attached and its SQL is only rendered in the context of this criteria. As the criteria has a field dbName by which the db adapter can be found out via Torque.getDB(criteria.getDbName()), I propose to remove the db field from Criterion together with its getters and setters and use the dbName field of the criteria instead to determine which Adapter should be used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Closed] (TORQUE-167) Remove the field Criteria.Criterion.db
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox closed TORQUE-167.
-----------------------------
> Remove the field Criteria.Criterion.db
> --------------------------------------
>
> Key: TORQUE-167
> URL: https://issues.apache.org/jira/browse/TORQUE-167
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0-beta1
>
>
> The db field of the Criterion specifies which database dialect is used for rendering this Criterion in SQL.
> In my opinion the database dialect should be determined from a criteria field, not from any nested object.
> Implications:
> As a criterion is no standalone class, but an inner class of a Criteria, it always has a criteria attached and its SQL is only rendered in the context of this criteria. As the criteria has a field dbName by which the db adapter can be found out via Torque.getDB(criteria.getDbName()), I propose to remove the db field from Criterion together with its getters and setters and use the dbName field of the criteria instead to determine which Adapter should be used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Updated] (TORQUE-167) Remove the field
Criteria.Criterion.db
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox updated TORQUE-167:
------------------------------
Summary: Remove the field Criteria.Criterion.db (was: Remove the filed Criteria.Criterion.db)
> Remove the field Criteria.Criterion.db
> --------------------------------------
>
> Key: TORQUE-167
> URL: https://issues.apache.org/jira/browse/TORQUE-167
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> The db field of the Criterion specifies which database dialect is used for rendering this Criterion in SQL.
> In my opinion the database dialect should be determined from a criteria field, not from any nested object.
> Implications:
> As a criterion is no standalone class, but an inner class of a Criteria, it always has a criteria attached and its SQL is only rendered in the context of this criteria. As the criteria has a field dbName by which the db adapter can be found out via Torque.getDB(criteria.getDbName()), I propose to remove the db field from Criterion together with its getters and setters and use the dbName field of the criteria instead to determine which Adapter should be used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Resolved] (TORQUE-167) Remove the field
Criteria.Criterion.db
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox resolved TORQUE-167.
-------------------------------
Resolution: Fixed
Fix Version/s: 4.0
> Remove the field Criteria.Criterion.db
> --------------------------------------
>
> Key: TORQUE-167
> URL: https://issues.apache.org/jira/browse/TORQUE-167
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0
>
>
> The db field of the Criterion specifies which database dialect is used for rendering this Criterion in SQL.
> In my opinion the database dialect should be determined from a criteria field, not from any nested object.
> Implications:
> As a criterion is no standalone class, but an inner class of a Criteria, it always has a criteria attached and its SQL is only rendered in the context of this criteria. As the criteria has a field dbName by which the db adapter can be found out via Torque.getDB(criteria.getDbName()), I propose to remove the db field from Criterion together with its getters and setters and use the dbName field of the criteria instead to determine which Adapter should be used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org