You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2025/10/06 23:38:53 UTC
[Impala-ASF-CR] PROTOTYPE: Add impala-package Maven project to simplify packaging
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23497
Change subject: PROTOTYPE: Add impala-package Maven project to simplify packaging
......................................................................
PROTOTYPE: Add impala-package Maven project to simplify packaging
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so it's classpath requires
no extra work when constructing the classpath.
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
4 files changed, 100 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23497/1
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23497
to look at the new patch set (#2).
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
IMPALA-14559: Ship calcite-planner jar in Impala packages
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so its classpath requires
no extra work when constructing the classpath.
This does not change the default value for the use_calcite_planner
query option, so there is no change in behavior.
Testing:
- Ran a core job
- Built docker images and OS packages locally
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
M package/CMakeLists.txt
5 files changed, 101 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23497/2
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23497
to look at the new patch set (#5).
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
IMPALA-14559: Ship calcite-planner jar in Impala packages
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so its classpath requires
no extra work when constructing the classpath.
An additional cleanup is that this no longer puts the
impala-frontend-*-tests.jar on the classpath by default. This requires
updating the query event hooks test, as it relies on that jar being
present.
This does not change the default value for the use_calcite_planner
query option, so there is no change in behavior.
Testing:
- Ran a core job
- Built docker images and OS packages locally
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
M package/CMakeLists.txt
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 119 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23497/5
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20971/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 22:27:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 03:36:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12692/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 23:30:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@41
PS4, Line 41: $PACKAGE_CP_FILE
> Nit: Need to double quote: "$PACKAGE_CP_FILE"
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@46
PS4, Line 46: $PACKAGE_CP_FILE
> Nit: Need to double quote: "$PACKAGE_CP_FILE"
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@50
PS4, Line 50: $FE_TEST_CP_FILE
> Nit: Need to double quote: "$FE_TEST_CP_FILE"
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py@80
PS4, Line 80: "target", "impala-frontend-{0}-tests.jar".format(os.getenv("IMPALA_VERSION")))
> Nit: Could move this into a separate function and eliminate the duplicate
Done
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Nov 2025 21:43:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12705/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 22:57:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@41
PS4, Line 41: $PACKAGE_CP_FILE
Nit: Need to double quote: "$PACKAGE_CP_FILE"
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@46
PS4, Line 46: $PACKAGE_CP_FILE
Nit: Need to double quote: "$PACKAGE_CP_FILE"
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@50
PS4, Line 50: $FE_TEST_CP_FILE
Nit: Need to double quote: "$FE_TEST_CP_FILE"
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py@80
PS4, Line 80: "target", "impala-frontend-{0}-tests.jar".format(os.getenv("IMPALA_VERSION")))
Nit: Could move this into a separate function and eliminate the duplicate code.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Nov 2025 18:41:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12687/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 02:30:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
IMPALA-14559: Ship calcite-planner jar in Impala packages
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so its classpath requires
no extra work when constructing the classpath.
An additional cleanup is that this no longer puts the
impala-frontend-*-tests.jar on the classpath by default. This requires
updating the query event hooks test, as it relies on that jar being
present.
This does not change the default value for the use_calcite_planner
query option, so there is no change in behavior.
Testing:
- Ran a core job
- Built docker images and OS packages locally
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Reviewed-on: http://gerrit.cloudera.org:8080/23497
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
M package/CMakeLists.txt
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 119 insertions(+), 40 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: Add impala-package Maven project to simplify packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: PROTOTYPE: Add impala-package Maven project to simplify packaging
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12543/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 23:41:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] PROTOTYPE: Add impala-package Maven project to simplify packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: PROTOTYPE: Add impala-package Maven project to simplify packaging
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20629/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 00:03:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 2: Code-Review+1
I'm pretty sure I follow this: The impala-package is added to the java/pom.xml file, which creates the package txt file. The set-classpath will automatically pick this up now because that file is guaranteed to exist as part of the build.
While I'm good to go on this and give it a +1, I'm wondering if there's any good place to document this. This wouldn't be straightforward to understand if I just started on the Impala project. I wouldn't stop that from pushing this, but figured I'd mention it if you could think of a good place.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 21:27:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4:
Ran an exhaustive job without issue
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Nov 2025 17:15:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 6:
> Patch Set 5:
>
> I think we should probably have some sort of README in the java/ directory.
Some docs would be good. It took me awhile to understand why this approach was taken. My understanding is this approach utilizes Maven's dependency resolution process to ensure duplicate dependencies are not added to the classpath.
That prompts something else -- if adding a readme, please also add a comment in java/impala-package/pom.xml that the impala-frontend dependency should be listed first to help conflicting dependency versions to favor the dependency version required by impala-frontend.
Once we get off Java 8, we should look into java modules, but that's for another day.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 23:54:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@41
PS4, Line 41: "$PACKAGE_CP_FIL
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@46
PS4, Line 46: "$PACKAGE_CP_FIL
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@50
PS4, Line 50: "$FE_TEST_CP_FIL
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py@80
PS4, Line 80: pytest.skip('runs only in exhaustive')
> Done
Done
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 17:31:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Nov 2025 04:01:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 22:56:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20988/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Nov 2025 22:09:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 2:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23497/2/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/2/bin/set-classpath.sh@50
PS2, Line 50: CLASSPATH="$IMPALA_HOME"/fe/target/impala-frontend-${IMPALA_VERSION}-tests.jar:"$CLASSPATH"
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 02:31:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE: Add impala-package Maven project to simplify packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: PROTOTYPE: Add impala-package Maven project to simplify packaging
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12543/
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 04:23:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 3:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23497/3/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/3/bin/set-classpath.sh@50
PS3, Line 50: CLASSPATH="$IMPALA_HOME"/fe/target/impala-frontend-${IMPALA_VERSION}-tests.jar:"$CLASSPATH"
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 21:44:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 5:
> I'm pretty sure I follow this: The impala-package is added to the
> java/pom.xml file, which creates the package txt file. The
> set-classpath will automatically pick this up now because that file
> is guaranteed to exist as part of the build.
>
> While I'm good to go on this and give it a +1, I'm wondering if
> there's any good place to document this. This wouldn't be
> straightforward to understand if I just started on the Impala
> project. I wouldn't stop that from pushing this, but figured I'd
> mention it if you could think of a good place.
I think we should probably have some sort of README in the java/ directory.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 22:57:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20963/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 02:55:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23497
to look at the new patch set (#4).
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
IMPALA-14559: Ship calcite-planner jar in Impala packages
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so its classpath requires
no extra work when constructing the classpath.
An additional cleanup is that this no longer puts the
impala-frontend-*-tests.jar on the classpath by default. This requires
updating the query event hooks test, as it relies on that jar being
present.
This does not change the default value for the use_calcite_planner
query option, so there is no change in behavior.
Testing:
- Ran a core job
- Built docker images and OS packages locally
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
M package/CMakeLists.txt
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 115 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23497/4
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20970/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 22:07:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Nov 2025 17:45:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23497
to look at the new patch set (#3).
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
IMPALA-14559: Ship calcite-planner jar in Impala packages
This adds the java/impala-package Maven project to make it easier
to ship / test the Calcite planner. impala-package has a dependency
on impala-frontend and calcite-planner, so its classpath requires
no extra work when constructing the classpath.
An additional cleanup is that this no longer puts the
impala-frontend-*-tests.jar on the classpath by default. This requires
updating the query event hooks test, as it relies on that jar being
present.
This does not change the default value for the use_calcite_planner
query option, so there is no change in behavior.
Testing:
- Ran a core job
- Built docker images and OS packages locally
Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
---
M bin/set-classpath.sh
M docker/setup_build_context.py
A java/impala-package/pom.xml
M java/pom.xml
M package/CMakeLists.txt
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 114 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23497/3
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: Add impala-package Maven project to simplify packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: PROTOTYPE: Add impala-package Maven project to simplify packaging
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23497/1/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/23497/1/bin/set-classpath.sh@50
PS1, Line 50: CLASSPATH="$IMPALA_HOME"/fe/target/impala-frontend-${IMPALA_VERSION}-tests.jar:"$CLASSPATH"
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 23:40:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14559: Ship calcite-planner jar in Impala packages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12687/
--
To view, visit http://gerrit.cloudera.org:8080/23497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793
Gerrit-Change-Number: 23497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 07:12:09 +0000
Gerrit-HasComments: No