You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/16 14:14:10 UTC
[GitHub] [incubator-skywalking] peng-yongsheng commented on a change in pull
request #2368: Support Exporter in core
peng-yongsheng commented on a change in pull request #2368: Support Exporter in core
URL: https://github.com/apache/incubator-skywalking/pull/2368#discussion_r266202330
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/indicator/WithMetadata.java
##########
@@ -16,13 +16,13 @@
*
*/
-package org.apache.skywalking.oap.server.core.alarm;
+package org.apache.skywalking.oap.server.core.analysis.indicator;
/**
- * Alarm supported interface implementor could return the {@link AlarmMeta}
+ * Alarm supported interface implementor could return the {@link IndicatorMetaInfo}
Review comment:
From the action of class name change, I think this class will not just for support alarm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services