You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/06/02 07:19:16 UTC
[GitHub] [arrow] candiduslynx opened a new pull request, #35885: MINOR: [Go] Add `arrow.ListLikeType` interface
candiduslynx opened a new pull request, #35885:
URL: https://github.com/apache/arrow/pull/35885
### Rationale for this change
Add `arrow.ListLikeType` interface corresponding to `array.ListLike` implementations.
### What changes are included in this PR?
1. Added `arrow.ListLikeType`
2. Some receivers changed from value to pointer (per Go recommendation to have either one of them, but not both)
### Are these changes tested?
No (per it mainly being the interface addition)
### Are there any user-facing changes?
1. Added `arrow.ListLikeType`
2. Some receivers changed from value to pointer (per Go recommendation to have either one of them, but not both)
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35885: MINOR: [Go] Add `arrow.ListLikeType` interface
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35885:
URL: https://github.com/apache/arrow/pull/35885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35885: MINOR: [Go] Add `arrow.ListLikeType` interface
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35885:
URL: https://github.com/apache/arrow/pull/35885#issuecomment-1575186156
Benchmark runs are scheduled for baseline = cd42895a0a8b6fa21be5bc06d13d771bef0d4fb3 and contender = fb0c72c0df059d8fd2c66f8aab55fa1290926a86. fb0c72c0df059d8fd2c66f8aab55fa1290926a86 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fc14070dcb2645679a85f421f48fa032...67c592efa7584dd99fae76ea9f4ac23f/)
[Finished :arrow_down:0.79% :arrow_up:0.09%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1d8a29a5c2a1432b9df2f060b7bffe54...135733694de14b2da60684263e73236d/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/dff44a41d0b6439285805a071c79a9a0...d8c8a05e1f8b4f08b041ccb9665655a4/)
[Finished :arrow_down:0.12% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c94ed995a5b545039740aaa81a04cff0...15f34e339c4d4d0db45af46741dc6670/)
Buildkite builds:
[Finished] [`fb0c72c0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2974)
[Finished] [`fb0c72c0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3010)
[Failed] [`fb0c72c0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2975)
[Finished] [`fb0c72c0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3000)
[Finished] [`cd42895a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2973)
[Finished] [`cd42895a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3009)
[Failed] [`cd42895a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2974)
[Finished] [`cd42895a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2999)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org