You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "liujiayi771 (via GitHub)" <gi...@apache.org> on 2024/07/25 07:26:57 UTC
[I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
liujiayi771 opened a new issue, #6564:
URL: https://github.com/apache/kyuubi/issues/6564
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
Currently, Authz will check check the update privilege for the column of the table. I think it is better to check the update privilege for the table.
```
insert into test values(1);
user [xxx] does not have [update] privilege on [database=testdb/table=test/column=id]
```
### How should we improve?
check the update privilege for the table.
### Are you willing to submit PR?
- [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2254830857
cc @yaooqinn, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2249642347
Hello @liujiayi771,
Thanks for finding the time to report the issue!
We really appreciate the community's efforts to improve Apache Kyuubi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2249643204
Hi @pan3793. How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2256075278
Thanks for checking, please go ahead to submit PR to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2256036174
@pan3793 I have tested Hive and Trino ranger plugin. They all check the privilege of table when insert into table.
Hive:
```
Error: Error while compiling statement: FAILED: HiveAccessControlException Permission denied: user [ranger] does not have [UPDATE] privilege on [database=testdb/table=test] (state=42000,code=40000)
```
Trino:
```
trino:testdb> insert into test values(1);
Query 20240729_135814_00054_g5bf9 failed: Access Denied: Cannot insert into table test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #6564:
URL: https://github.com/apache/kyuubi/issues/6564#issuecomment-2255068385
sounds reasonable to me, but can we double check other DBs implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [AUTHZ][Improvement] insert into table should check the update privilege for table [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed issue #6564: [AUTHZ][Improvement] insert into table should check the update privilege for table
URL: https://github.com/apache/kyuubi/issues/6564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org