You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by di...@apache.org on 2026/09/15 17:21:31 UTC

(superset) 01/01: feat(ci): flag chart metadata changes via labeler

This is an automated email from the ASF dual-hosted git repository.

geido pushed a commit to branch geido/feat/ci-metadata-backward-check
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 7728126936e4e46e735de785f10701b1263c60a3
Author: Diego Pucci <ge...@192.168.0.8>
AuthorDate: Tue Sep 15 19:14:04 2026 +0300

    feat(ci): flag chart metadata changes via labeler
    
    A chart's `controlPanel` defines the form_data keys persisted on every
    slice that uses it, and its `transformProps` reads those keys back at
    render time. Changing either can break charts and dashboards saved
    against the previous shape.
    
    Rather than adding a dedicated workflow that gates CI on a manually
    applied label, reuse the existing `actions/labeler` setup: touching a
    chart's metadata now applies `risk:chart-metadata`, matching the
    `risk:db-migration` and `risk:ci-script` warnings already in this file.
    
    Coverage is not limited to `superset-frontend/plugins` — native filters,
    chart customizations and TimeTable register through the same plugin API
    from `superset-frontend/src`, and native filter config is persisted in
    dashboard `json_metadata`. The globs match the metadata files themselves,
    so unit tests do not trigger the label.
    
    Co-Authored-By: Claude Opus 5 (1M context) <no...@anthropic.com>
---
 .github/labeler.yml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/.github/labeler.yml b/.github/labeler.yml
index 290cb5b2472..bc600bdadc7 100644
--- a/.github/labeler.yml
+++ b/.github/labeler.yml
@@ -22,6 +22,18 @@
   - any-glob-to-any-file:
     - 'scripts/**'
 
+# A chart's `controlPanel` defines the form_data keys persisted on every
+# slice that uses it, and its `transformProps` reads those keys back at
+# render time. Changing either can break charts and dashboards saved
+# against the previous shape. Covers chart plugins, native filters and
+# chart customizations, wherever they live in the frontend.
+"risk:chart-metadata":
+- changed-files:
+  - any-glob-to-any-file:
+    - 'superset-frontend/**/{controlPanel,transformProps}.{ts,tsx}'
+    - 'superset-frontend/**/config/{controlPanel,transformProps}/index.ts'
+    - 'superset-frontend/src/explore/controlPanels/**'
+
 ############################################
 # Dependencies
 ############################################