You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "W-M-R (via GitHub)" <gi...@apache.org> on 2024/04/07 08:44:22 UTC
[PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
W-M-R opened a new pull request, #12088:
URL: https://github.com/apache/nuttx/pull/12088
## Summary
Missing ARCH_TOOLCHAIN_GNU option causes sim's kasan recursion
## Impact
NO
## Testing
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #12088:
URL: https://github.com/apache/nuttx/pull/12088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554976987
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
sim doesn't support user switch to a different toolchain. it can be only compiled with the host default one. All of them compatible with gcc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554975713
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
@W-M-R but it doesn't sound correct to select a fixed toolchain, maybe the recursion issue should be fixed other way. What if the developer decide to use a toolchain different from GNU/GCC ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1555000220
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
In that case, the contributor just need move the selection to the toolchain which compatible with gcc. It's hard to find a better place to select ARCH_TOOLCHAIN_GNU before the toolchain selection is added to sim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554855641
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
why need select the toolchain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554857426
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
kasan/Makefile:
```
ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
CFLAGS += -fno-sanitize=kernel-address
ifeq ($(CONFIG_LTO_NONE),n)
CFLAGS += -fno-lto
endif
endif
```
If SIM does not select and mm does not turn off instrumentation, it will cause recursion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554857426
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
kasan/Makefile:
```
ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
CFLAGS += -fno-sanitize=kernel-address
ifeq ($(CONFIG_LTO_NONE),n)
CFLAGS += -fno-lto
endif
endif
```If SIM does not select and mm does not turn off instrumentation, it will cause recursion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sim/kconfig: select ARCH_TOOLCHAIN_GNU [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12088:
URL: https://github.com/apache/nuttx/pull/12088#discussion_r1554978668
##########
arch/sim/Kconfig:
##########
@@ -15,18 +15,22 @@ config HOST_X86_64
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
select ARCH_HAVE_MATH_H
+ select ARCH_TOOLCHAIN_GNU
Review Comment:
Thank you Xiang. But yet the solution seems like a "workaround", because if someone decide to add support to build sim using other toolchain this "fix" needs to be fixed again. So, maybe it is better to fix the root cause :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org