You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nitin-amp <gi...@git.apache.org> on 2016/03/08 20:10:52 UTC
[GitHub] incubator-geode pull request: GEODE-511 Residual 'Gemfire' fixed t...
GitHub user nitin-amp opened a pull request:
https://github.com/apache/incubator-geode/pull/110
GEODE-511 Residual 'Gemfire' fixed to Geode in Pulse
The tooltips in Pulse still showed **Gemfire** version. Change text to **Geode**.
Not sure if the pull request is setup correctly; it is pulling multiple commits. Did I do something wrong?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-amp/incubator-geode develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit 5597a9814494d13c4cb4bdcdcc42c3961356d129
Author: Nitin Lamba <ni...@ampool.io>
Date: 2016-03-06T18:56:57Z
GEODE-36 Interim fix to display correct product name on gfsh cli
commit 4bd0449338b181c4568fadc9db982ea9e382d88d
Author: Nitin Lamba <ni...@ampool.io>
Date: 2016-03-08T18:52:03Z
Merge branch 'develop' of git://git.apache.org/incubator-geode into develop
commit 153a7c8183c579a14424735d51f46f9a2b23bae2
Author: Nitin Lamba <ni...@ampool.io>
Date: 2016-03-08T19:02:35Z
GEODE-511 Residual 'Gemfire' fixed to Geode in Pulse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: GEODE-511 Residual 'Gemfire' fixed t...
Posted by scmbuildguy <gi...@git.apache.org>.
Github user scmbuildguy commented on the pull request:
https://github.com/apache/incubator-geode/pull/110#issuecomment-193926741
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: GEODE-511 Residual 'Gemfire' fixed t...
Posted by nitin-amp <gi...@git.apache.org>.
Github user nitin-amp commented on the pull request:
https://github.com/apache/incubator-geode/pull/110#issuecomment-193929252
Thanks Dan. I'll rebase and re-submit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: GEODE-511 Residual 'Gemfire' fixed t...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the pull request:
https://github.com/apache/incubator-geode/pull/110#issuecomment-193924869
+1
You should rebase your branch on apache develop. It looks like what happened is that your previous pull request was cherry-picked to develop and got a different hash. That's why you have a merge commit in this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: GEODE-511 Residual 'Gemfire' fixed t...
Posted by nitin-amp <gi...@git.apache.org>.
Github user nitin-amp closed the pull request at:
https://github.com/apache/incubator-geode/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---