You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/08 01:44:11 UTC

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #16272: [mkldnn-v1.0] Add MKL-DNN Pooling

rongzha1 commented on a change in pull request #16272: [mkldnn-v1.0] Add MKL-DNN Pooling
URL: https://github.com/apache/incubator-mxnet/pull/16272#discussion_r332306060
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling.cc
 ##########
 @@ -333,27 +292,31 @@ MKLDNNPoolingBwd &GetPoolingBwd(const PoolingParam &param,
 
   auto it = pooling_bwds.find(key);
   if (it == pooling_bwds.end()) {
-    auto diff_dst_mem = out_grad.GetMKLDNNData();
+    // mkldnn v1.0 add reoder to workaround testcase:test_make_subgraph;
+    // alread fixed in v1.1, will remove after v1.1 is integrated.
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services