You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/22 13:45:11 UTC
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18434: Add cascade to DagRun/TaskInstance relationship
ephraimbuddy commented on a change in pull request #18434:
URL: https://github.com/apache/airflow/pull/18434#discussion_r713958582
##########
File path: airflow/models/dagrun.py
##########
@@ -124,7 +124,7 @@ class DagRun(Base, LoggingMixin):
),
)
- task_instances = relationship(TI, back_populates="dag_run")
+ task_instances = relationship(TI, back_populates="dag_run", cascade='all, delete, delete-orphan')
Review comment:
Not sure the best option for us:
@uranusjr @ashb @kaxil
https://docs.sqlalchemy.org/en/14/orm/cascades.html#unitofwork-cascades
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org