[GitHub] [spark] cloud-fan commented on a change in pull request #35631: [SPARK-38229][FOLLOWUP][SQL] Clean up unnecessary code for code simplification

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35631:
URL: https://github.com/apache/spark/pull/35631#discussion_r812939930



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3543,7 +3534,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
    * }}}
    */
   override def visitReplaceTable(ctx: ReplaceTableContext): LogicalPlan = withOrigin(ctx) {
-    val table = visitReplaceTableHeader(ctx.replaceTableHeader)
+    val table = ctx.replaceTableHeader.multipartIdentifier.parts.asScala.map(_.getText).toSeq

Review comment:
       I think it's better to use `visitMultipartIdentifier(ctx.replaceTableHeader.multipartIdentifier)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org