You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by adriannieto <gi...@git.apache.org> on 2014/06/25 15:44:51 UTC
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
GitHub user adriannieto opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/18
Replaced Iterable<> return type with List<> in public API.
Using abstract return types in the API definition like Iterable or Collection, could lead into a deserialization problem at client side.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SeaCloudsEU/incubator-brooklyn master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit cdec13c94dd9cbe48ebb4dac985799da15b8feea
Author: Adrián Nieto <ad...@lcc.uma.es>
Date: 2014-06-25T13:37:42Z
Replaced Iterable<> return type with List<> in public API to avoid deserialization errors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/18#issuecomment-47211293
good fix, as per https://github.com/brooklyncentral/brooklyn/pull/1435.
let's merge.
@adriannieto have you filed an ICLA with apache? probably not needed for this PR as it's small, but will be needed for your next ones i'm sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by adriannieto <gi...@git.apache.org>.
Github user adriannieto commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/18#issuecomment-47213850
Anyway, please pay attention that i made a mistake using diamond operator in Java6. My machine targets to 1.7 so i breaks the building process in the main branch. I will update the source in order to support it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/18#issuecomment-47213481
sure - see https://brooklyn.incubator.apache.org/community/how-to-contribute.html . do not worry about opening a jira issue for this small one, but the CLA link is there in the first para
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/18#issuecomment-47215866
thanks - i missed that `<>` which snuck in. we need to get cloudbees enabled for the new incubating-brooklyn .
merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by adriannieto <gi...@git.apache.org>.
Github user adriannieto commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/18#issuecomment-47212943
@ahgittin it's my first contribution to an Apache Project, could you point me about the necessary steps to follow? Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Replaced Iterable<> return type w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---