[GitHub] [nifi] ijokarumawak commented on issue #3351: NIFI-2933 Remote input/output ports at any PG

[GitBox <gi...@apache.org>]

ijokarumawak commented on issue #3351: NIFI-2933 Remote input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#issuecomment-471825382
 
 
   Thanks @markap14 for reviewing this!
   
   The last commit resolves most review comments except the big one, separate private LocalPort and public LocalPort.
   
   I've been feeling the same oddness with current implementation as Mark called out. Now I think the 'Allow Remote Access' property should be immutable once the LocalPort is created.
   
   BTW, port type names are confusing. It may be useful if we document it somewhere.. Currently, terminologies are like these with this branch:
   - RemotePort: Resides in a RemoteProcessGroup, representing a port at the remote Site-to-Site target NiFi instance.
   - RootGroupPort: Resides in the root ProcessGroup of a local flow. Always accessible remotely.
   - LocalPort:
       - public LocalPort: Enabled 'Allow Remote Access'. Only accepts incoming connections via S2S.
       - private LocalPort: Only accepts incoming connections via local connections.
   
   
   I will refactor this PR as follows, to make 'Allow Remote Access' immutable:
   - Show 'Allow Remote Access' as checkbox at the initial port creation dialog
   - After creation, show it as a label in the Port configuration dialog instead of checkbox
   - Hide 'Concurrent Tasks' for Local private port.
   - Revert some UI Javascripts those were needed to support dynamic port type change
   - Modify server side validations those were needed to support dynamic port type change
   
   For authorization error message improvement, I created https://issues.apache.org/jira/browse/NIFI-6114

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services