[GitHub] [arrow-datafusion] alamb commented on issue #5644: Discuss: Should we implement custom lints?

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on issue #5644:
URL: https://github.com/apache/arrow-datafusion/issues/5644#issuecomment-1476381668

   I worry if we require a non standard rust tool (like some clippy plugin) that would make it harder for people to contribute to datafusion as it would raise the barrier to entry
   
   
   Tuning the existing standard tools to make the codebase more consistent, is a great idea, in my opinion
   
   For example, we might consider enabling more  clippy lints:
   https://github.com/influxdata/influxdb_iox/blob/c0a53ae5a99c12dd50c9eb2772afefc8430d622c/querier/src/lib.rs#L2-L11
   
   ```rust
   #![warn(
       missing_copy_implementations,
       missing_docs,
       clippy::explicit_iter_loop,
       clippy::future_not_send,
       clippy::use_self,
       clippy::clone_on_ref_ptr,
       clippy::todo,
       clippy::dbg_macro
   )]
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org