You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by aa...@apache.org on 2022/12/08 05:21:17 UTC

[rocketmq-clients] branch master updated: Polish java example

This is an automated email from the ASF dual-hosted git repository.

aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new db17579c Polish java example
db17579c is described below

commit db17579cfd1a70407fdfd3b19926a0ca0c65fe7b
Author: Aaron Ai <ya...@gmail.com>
AuthorDate: Thu Dec 8 13:13:26 2022 +0800

    Polish java example
---
 .../apache/rocketmq/client/java/example/AsyncProducerExample.java    | 5 +++--
 .../rocketmq/client/java/example/ProducerDelayMessageExample.java    | 5 +++--
 .../rocketmq/client/java/example/ProducerFifoMessageExample.java     | 5 +++--
 .../rocketmq/client/java/example/ProducerNormalMessageExample.java   | 5 +++--
 .../client/java/example/ProducerTransactionMessageExample.java       | 5 +++--
 5 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/AsyncProducerExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/AsyncProducerExample.java
index 832be4d5..50632c88 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/AsyncProducerExample.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/AsyncProducerExample.java
@@ -52,10 +52,11 @@ public class AsyncProducerExample {
             .setCredentialProvider(sessionCredentialsProvider)
             .build();
         String topic = "yourTopic";
+        // In most case, you don't need to create too many producers, singleton pattern is recommended.
         final Producer producer = provider.newProducerBuilder()
             .setClientConfiguration(clientConfiguration)
-            // Set the topic name(s), which is optional. It makes producer could prefetch the topic route before 
-            // message publishing.
+            // Set the topic name(s), which is optional but recommended. It makes producer could prefetch the topic
+            // route before message publishing.
             .setTopics(topic)
             // May throw {@link ClientException} if the producer is not initialized.
             .build();
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerDelayMessageExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerDelayMessageExample.java
index 5372a7e8..1d128f32 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerDelayMessageExample.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerDelayMessageExample.java
@@ -52,10 +52,11 @@ public class ProducerDelayMessageExample {
             .setCredentialProvider(sessionCredentialsProvider)
             .build();
         String topic = "yourDelayTopic";
+        // In most case, you don't need to create too many producers, singleton pattern is recommended.
         final Producer producer = provider.newProducerBuilder()
             .setClientConfiguration(clientConfiguration)
-            // Set the topic name(s), which is optional. It makes producer could prefetch the topic route before
-            // message publishing.
+            // Set the topic name(s), which is optional but recommended. It makes producer could prefetch the topic
+            // route before message publishing.
             .setTopics(topic)
             // May throw {@link ClientException} if the producer is not initialized.
             .build();
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerFifoMessageExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerFifoMessageExample.java
index ca0ce397..e8bbb055 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerFifoMessageExample.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerFifoMessageExample.java
@@ -51,10 +51,11 @@ public class ProducerFifoMessageExample {
             .setCredentialProvider(sessionCredentialsProvider)
             .build();
         String topic = "yourFifoTopic";
+        // In most case, you don't need to create too many producers, singleton pattern is recommended.
         final Producer producer = provider.newProducerBuilder()
             .setClientConfiguration(clientConfiguration)
-            // Set the topic name(s), which is optional. It makes producer could prefetch the topic route before 
-            // message publishing.
+            // Set the topic name(s), which is optional but recommended. It makes producer could prefetch the topic
+            // route before message publishing.
             .setTopics(topic)
             // May throw {@link ClientException} if the producer is not initialized.
             .build();
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java
index f19ef734..b0dde2ca 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java
@@ -51,10 +51,11 @@ public class ProducerNormalMessageExample {
             .setCredentialProvider(sessionCredentialsProvider)
             .build();
         String topic = "yourNormalTopic";
+        // In most case, you don't need to create too many producers, singleton pattern is recommended.
         final Producer producer = provider.newProducerBuilder()
             .setClientConfiguration(clientConfiguration)
-            // Set the topic name(s), which is optional. It makes producer could prefetch the topic route before 
-            // message publishing.
+            // Set the topic name(s), which is optional but recommended. It makes producer could prefetch the topic
+            // route before message publishing.
             .setTopics(topic)
             // May throw {@link ClientException} if the producer is not initialized.
             .build();
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerTransactionMessageExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerTransactionMessageExample.java
index a3f90f2f..a538ae0c 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerTransactionMessageExample.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerTransactionMessageExample.java
@@ -59,10 +59,11 @@ public class ProducerTransactionMessageExample {
             // Return the transaction resolution according to your business logic.
             return TransactionResolution.COMMIT;
         };
+        // In most case, you don't need to create too many producers, singleton pattern is recommended.
         Producer producer = provider.newProducerBuilder()
             .setClientConfiguration(clientConfiguration)
-            // Set the topic name(s), which is optional. It makes producer could prefetch the topic route before
-            // message publishing.
+            // Set the topic name(s), which is optional but recommended. It makes producer could prefetch the topic
+            // route before message publishing.
             .setTopics(topic)
             // Set transactional checker.
             .setTransactionChecker(checker)