[GitHub] [iceberg] rdblue commented on a change in pull request #1783: Custom catalogs from `IcebergSource`

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1783:
URL: https://github.com/apache/iceberg/pull/1783#discussion_r533022447



##########
File path: spark3/src/test/java/org/apache/iceberg/spark/source/SetupSourceCatalog.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.iceberg.spark.source;
+
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.spark.SparkSessionCatalog;
+import org.apache.spark.sql.SparkSession;
+
+public final class SetupSourceCatalog {
+
+  private SetupSourceCatalog() {
+
+  }
+
+  public static void setupSparkCatalog(SparkSession spark) {
+    setupSparkCatalog(spark, SparkSessionCatalog.class.getName());
+  }
+
+  public static void setupSparkCatalog(SparkSession spark, String catalogName) {

Review comment:
       I don't think `catalogName` is accurate because catalogs have names (this one is `spark_catalog`). It should be `catalogClass` to be more clear.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org