You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Fernanda Pizzorno (JIRA)" <ji...@apache.org> on 2006/10/31 18:45:19 UTC
[jira] Created: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
convert lang/updatableResultSet.java to Junit
---------------------------------------------
Key: DERBY-2025
URL: http://issues.apache.org/jira/browse/DERBY-2025
Project: Derby
Issue Type: Sub-task
Reporter: Fernanda Pizzorno
Assigned To: Fernanda Pizzorno
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=comments#action_12454623 ]
Knut Anders Hatlen commented on DERBY-2025:
-------------------------------------------
Thank you for addressing my comments, Fernanda. I think v3 looks good. +1 to commit.
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat, derby-2025v3.diff, derby-2025v3.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-2025) convert lang/updatableResultSet.java to
Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno closed DERBY-2025.
------------------------------------
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Fix For: 10.3.0.0
>
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat, derby-2025v3.diff, derby-2025v3.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno updated DERBY-2025:
-------------------------------------
Attachment: derby-2025v3.diff
derby-2025v3.stat
I have changed verifyData() in the attached patch(derby-2025v3.diff) so that it uses the ResultSet.getBytes() method instead of ResultSet.getString() when verifying the use of the ResultSet.updateBytes method on columns of type CHAR, VARCHAR or LONG VARCHAR.
I have successfully run lang/_Suite with this patch. Can someone please review it?
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat, derby-2025v3.diff, derby-2025v3.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno updated DERBY-2025:
-------------------------------------
Derby Info: [Patch Available]
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2025:
----------------------------------
Component/s: Test
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: https://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Fix For: 10.3.1.4
>
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat, derby-2025v3.diff, derby-2025v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=comments#action_12453601 ]
Knut Anders Hatlen commented on DERBY-2025:
-------------------------------------------
The patch looks good. Some small comments:
- I believe testResultSetPositionedBeforeNextAfterDeleteRow() is missing fail() after rs.getString(1)
- testUpdateXXXNotForUpdateColumns() is missing fail() after rs.updateInt()
- in testInsertRowReadOnlyRS(), rs.updateInt(2, 5000) is unreachable because fail() is called on the line before
- testDeleteRowWithSetCursorName(), testUpdateRowWithSetCursorName(), runTestUpdateXXXWithAllDatatypes(), runTestUpdateObjectWithAllDatatypes() and verifyData() have asserts or calls to fail() which cause errors when an unexpected exception is called. Wouldn't it be better to re-throw the exceptions in order to preserve the stack traces?
- testUpdateXXXWithAllDatatypes() and testUpdateObjectWithAllDatatypes() have finally clauses which clean up the database. If an error happens in the test case, an error in the finally clause might hide the actual error.
- tearDown() could be removed since it doesn't do anything super.tearDown() wouldn't do
- Would it be better if the suite were constructed from a baseSuite() method which returned all test cases with no decorator? suite() could return a test suite with baseSuite() + clientServerDecorator(baseSuite()). Then we wouldn't have to start/stop the network server more than once.
- typo in class javadoc: resutlset
- typo in comment in suite(): XtestInsertRowAftrerCommit
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno updated DERBY-2025:
-------------------------------------
Attachment: derby-2025v2.diff
derby-2025v2.stat
Thank you for looking at the patch Knut Anders. The attached patch (derby-2025v2.diff) addresses your comments.
I have succesfully run lang/_Suite with this patch. Can someone please review it?
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno resolved DERBY-2025.
--------------------------------------
Fix Version/s: 10.3.0.0
Resolution: Fixed
Derby Info: (was: [Patch Available])
Committed revision 481252.
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Fix For: 10.3.0.0
>
> Attachments: derby-2025v1.diff, derby-2025v1.stat, derby-2025v2.diff, derby-2025v2.stat, derby-2025v3.diff, derby-2025v3.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-2025) convert lang/updatableResultSet.java
to Junit
Posted by "Fernanda Pizzorno (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-2025?page=all ]
Fernanda Pizzorno updated DERBY-2025:
-------------------------------------
Attachment: derby-2025v1.diff
derby-2025v1.stat
The attached patch (derby-2025v1.diff) converts the test lang/updatableResultSet.java to Junit.
A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/UpdatableResultSetTestCoverage.
I have successfully run lang._Suite with this patch. Can someone please review it?
> convert lang/updatableResultSet.java to Junit
> ---------------------------------------------
>
> Key: DERBY-2025
> URL: http://issues.apache.org/jira/browse/DERBY-2025
> Project: Derby
> Issue Type: Sub-task
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2025v1.diff, derby-2025v1.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira